-
Notifications
You must be signed in to change notification settings - Fork 542
[EXTERNAL] docs(0-shell + optionals): refactoring of 0-shell & its optionals' docs
#2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello @heshamalmosawi! We appreciate your extensive PR. Your contributions are very much appreciated! In general all the changes you presented seem good and well justified. In regards to the python situation - You make a great point. The point of the python command is to see that the process is spawned and then terminated, while the Once again, thank you so much for your time! We appreciate it. |
|
Hello @pedrodesu, Although, there is still a gap with making the Please review the changes and feel free to edit, or have additions, or let me know so I can add those changes. |
0-shell optionals): refactoring of 0-shell optional docs0-shell + optionals): refactoring of 0-shell & its optionals' docs
|
In regards to the |
Hello @pedrodesu, For instance, instead of the first question being run As I'm writing this, I suppose that having another |
Why?
This project has unclear and inconsistent requirements to the audit file, as well as having redundant audit files. This fix attempt to solve some of the inconsistencies, however in the solution overview will mention some of the unclear gaps still remaining in the requirements and left up to the maintainers to fix as they see fit.
This project has inconsistent requirements, as well as having redundant audit files.
Implementation Details
audit/README.mdfile to stay consistent with other projects.0-shellproject.Command::newto spawn a python process. The other unclear point is the use of2>1 >/dev/null, I was not sure about this point, as it was not required in the main project, so i left it up to the 01 staff to decide how to introduce this, as well as if my python fix is sufficient.audit/README.mdand removed the one in the root to stay consistent with other projects.0-shellproject.