Merge pull request #532 from ElektroKill/fix/pdb-writer-incorrect-column-sizes

Fix incorrect column sizes when writing portable or embedded PDB files

Author: wtfsck

src/DotNet/Writer/TablesHeap.cs

@@ -353,7 +353,19 @@ public void CalculateLength() {
 			var dnTableSizes = new DotNetTableSizes();
 			var tableInfos = dnTableSizes.CreateTables(majorVersion, minorVersion);
 			var rowCounts = GetRowCounts();
-			dnTableSizes.InitializeSizes(bigStrings, bigGuid, bigBlob, systemTables ?? rowCounts, rowCounts, options.ForceBigColumns ?? false);
+
+			var debugSizes = rowCounts;
+			if (systemTables is not null) {
+				debugSizes = new uint[rowCounts.Length];
+				for (int i = 0; i < rowCounts.Length; i++) {
+					if (DotNetTableSizes.IsSystemTable((Table)i))
+						debugSizes[i] = systemTables[i];
+					else
+						debugSizes[i] = rowCounts[i];
+				}
+			}
+
+			dnTableSizes.InitializeSizes(bigStrings, bigGuid, bigBlob, rowCounts, debugSizes, options.ForceBigColumns ?? false);
 			for (int i = 0; i < Tables.Length; i++)
 				Tables[i].TableInfo = tableInfos[i];