Use the session locale on OIDC requests with no locale param #12024
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When partners initiate an authentication they can include a locale in the request which we honor when we render the next page. However, many partners do not do this and we assume the default locale of English. If the user was previously on Login.gov they may have a locale in the session. This commit changes the IdP to honor that locale if no locale is present in the OIDC authorization request. This fixes the following weird behaviors: _The step up flow_: 1. The user authenticates for auth-only and selects a non-English locale for that 2. The user is reidrected to the SP 3. The SP determines the user needs to identity proof and redirects back to Login.gov 4. The user's language choice is not longer respected _The post-IdV follow up flow_: 1. The user enters a GPO code. They elect to do so with a non-English locale 2. They are presented the post-IdV follow up button on the next screen. They click the button to proceed to the service provider 3. The service provider recognizes it needs attributes from the user. It makes a redirect back to the IdP for the OIDC authorization endpoint 4. The user sees the screen to share proofed attributes. The language preference is no longer respected on this screen This change causes the languge preference to be respected in both of these cases. [skip changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partners initiate an authentication they can include a locale in the request which we honor when we render the next page. However, many partners do not do this and we assume the default locale of English.
If the user was previously on Login.gov they may have a locale in the session. This commit changes the IdP to honor that locale if no locale is present in the OIDC authorization request. This fixes the following weird behaviors:
The step up flow:
The post-IdV follow up flow:
This change causes the language preference to be respected in both of these cases.