Skip to content

Conversation

@JillRegan
Copy link
Contributor

@JillRegan JillRegan commented Nov 25, 2025

✨ Summary

  • Adds E2E test TestAccItemResourceWithAccount which uses desktop auth to get items.
  • This test can only be run locally and user needs to create a vault called Terraform Test Vault in order to run

🔗 Resolves:

  • Creates test for desktop auth with SDK

✅ Checklist

  • 🖊️ Commits are signed
  • 🧪 Tests added/updated: (See the Testing Guide for when to use each type and how to run them)
    • 🔹 Unit /🔸 Integration
    • 🌐 E2E
  • 📚 Docs updated (if behavior changed)

🕵️ Review Notes & ⚠️ Risks

  • Can only be tested locally, is skipped in the pipeline

@JillRegan JillRegan changed the title [DRAFT] Add account e2e tests Add account e2e tests Nov 26, 2025
@JillRegan JillRegan marked this pull request as ready for review November 28, 2025 16:57
Base automatically changed from jill/add-e2e-test-for-state-management to feature/configure-provider-to-use-sdk December 2, 2025 18:47
@volodymyrZotov
Copy link
Contributor

This test can only be run locally and user needs to create a vault called Terraform Test Vault in order to run

Could you mention this in docs/testing/testing.md, please?

Can be done in a followup PR, as I we also need to update there instructions about setting Connect env vars.

@sh -c 'unset OP_SERVICE_ACCOUNT_TOKEN; OP_CONNECT_TOKEN="$(OP_CONNECT_TOKEN)" OP_CONNECT_HOST="$(OP_CONNECT_HOST)" TF_ACC=1 go test -v ./test/e2e/... -timeout 30m'

test-e2e-account: ## Run e2e test using account methodology with Touch ID (requires OP_ACCOUNT, manual only). Creates multiple items to verify biometrics is only prompted once.
@test -n "$(OP_ACCOUNT)" || (echo "[ERROR] OP_ACCOUNT environment variable is not set."; exit 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the same check for OP_TEST_VAULT_NAME env var, so it doesn't run tests if it's not set.

@JillRegan JillRegan merged commit 97edd98 into feature/configure-provider-to-use-sdk Dec 2, 2025
8 checks passed
@JillRegan JillRegan deleted the jill/add-account-e2e-tests branch December 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants