Skip to content

Commit e556287

Browse files
committed
#656 Make offset types exhaustive when matching in SQL generators.
1 parent 917de9a commit e556287

11 files changed

+22
-0
lines changed

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDatabricks.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ class SqlGeneratorDatabricks(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlC
118118
s"$column $condition $value"
119119
case OffsetValue.StringValue(value) =>
120120
s"$column $condition '$value'"
121+
case t =>
122+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Databricks SQL query generator.")
121123
}
122124
}
123125

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDb2.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ class SqlGeneratorDb2(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig)
104104
s"$column $condition $value"
105105
case OffsetValue.StringValue(value) =>
106106
s"$column $condition '$value'"
107+
case t =>
108+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in DB2 SQL query generator.")
107109
}
108110
}
109111

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDenodo.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ class SqlGeneratorDenodo(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
122122
s"$column $condition $value"
123123
case OffsetValue.StringValue(value) =>
124124
s"$column $condition '$value'"
125+
case t =>
126+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Denodo SQL query generator.")
125127
}
126128
}
127129

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorGeneric.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ class SqlGeneratorGeneric(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConf
104104
s"$column $condition $value"
105105
case OffsetValue.StringValue(value) =>
106106
s"$column $condition '$value'"
107+
case t =>
108+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in the generic SQL query generator.")
107109
}
108110
}
109111

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHive.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ class SqlGeneratorHive(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig)
118118
s"$column $condition $value"
119119
case OffsetValue.StringValue(value) =>
120120
s"$column $condition '$value'"
121+
case t =>
122+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Hive SQL query generator.")
121123
}
122124
}
123125

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHsqlDb.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ class SqlGeneratorHsqlDb(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
104104
s"$column $condition $value"
105105
case OffsetValue.StringValue(value) =>
106106
s"$column $condition '$value'"
107+
case t =>
108+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in HSQLDB SQL query generator.")
107109
}
108110
}
109111

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorMicrosoft.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,8 @@ class SqlGeneratorMicrosoft(sqlConfig: SqlConfig) extends SqlGenerator {
190190
s"$column $condition $value"
191191
case OffsetValue.StringValue(value) =>
192192
s"$column $condition '$value'"
193+
case t =>
194+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in MS SQL Server query generator.")
193195
}
194196
}
195197

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorMySQL.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ class SqlGeneratorMySQL(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig
100100
s"$column $condition $value"
101101
case OffsetValue.StringValue(value) =>
102102
s"$column $condition '$value'"
103+
case t =>
104+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in MySQL query generator.")
103105
}
104106
}
105107

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorOracle.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ class SqlGeneratorOracle(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfi
9797
s"$column $condition $value"
9898
case OffsetValue.StringValue(value) =>
9999
s"$column $condition '$value'"
100+
case t =>
101+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in Oracle SQL query generator.")
100102
}
101103
}
102104

pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorPostgreSQL.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ class SqlGeneratorPostgreSQL(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlC
100100
s"$column $condition $value"
101101
case OffsetValue.StringValue(value) =>
102102
s"$column $condition '$value'"
103+
case t =>
104+
throw new IllegalArgumentException(s"Offset type [${t.dataType.dataTypeString}] is not supported in PostgreSQL query generator.")
103105
}
104106
}
105107

0 commit comments

Comments
 (0)