Skip to content

S3a support #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jozefbakus wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

S3a support #61

jozefbakus wants to merge 2 commits into from

Conversation

@jozefbakus
Copy link
Collaborator

@jozefbakus jozefbakus commented Oct 5, 2023

S3a support

@jozefbakus jozefbakus requested a review from filiphornak October 5, 2023 15:15
@jozefbakus jozefbakus self-assigned this Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

JaCoCo code coverage report - scala:2.13

File Coverage [23.54%] ❌
S3FileManager.scala 65.8% ❌
TargetFileSystem.scala 0% ❌
ArgumentParser.scala 0% ❌
Application.scala 0% ❌
Total Project Coverage 58.7% 🍏

kevinwallimann
kevinwallimann reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@kevinwallimann kevinwallimann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this yet, otherwise lgtm

src/main/scala/za/co/absa/spark_metadata_tool/io/S3FileManager.scala Outdated
import scala.util.chaining._

case class S3FileManager(s3: S3Client) extends FileManager {
case class S3FileManager(s3: S3Client, schema: String) extends FileManager {
Copy link
Collaborator

@kevinwallimann kevinwallimann Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename schema -> scheme. These are not the same things.

Copy link
Collaborator Author

@jozefbakus jozefbakus Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinwallimann kevinwallimann kevinwallimann approved these changes

@filiphornak filiphornak Awaiting requested review from filiphornak

Assignees

@jozefbakus jozefbakus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jozefbakus @kevinwallimann