bug: Unskip it tests in JS benchmark
#4587
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most tests in the javascript polyglot-benchmark use
test:https://github.com/Aider-AI/polyglot-benchmark/blob/main/javascript/exercises/practice/connect/connect.spec.js
The
grepproblem usesit:https://github.com/Aider-AI/polyglot-benchmark/blob/main/javascript/exercises/practice/grep/grep.spec.js
This PR updates the npm-test.sh script to also replace
xitwithit, so that the grep problem tests the full test suite instead of just two tests. They're used pretty interchangeably in the JS / TS ecosystems, so I think it's worth supporting both rather than changing thegrepsource.