When encrypting, is there an error in `calculateChunkIndex`?

[cnkLmxf]

When encryption is enabled in calculateChunkIndex, will there be any anomalies in originalFileSize - transformedChunkSize? Shouldn't it be transformedFileSize - transformedChunkSize?

   
private ChunkIndex calculateChunkIndex() {

        final var chunkSize = inner.transformedChunkSize();

        var size = originalFileSize;

        while (size > chunkSize) {

            chunkIndexBuilder.addChunk(chunkSize);

            size -= chunkSize;

        }

        return chunkIndexBuilder.finish(size);

    }```

[AnatolyPopov]

Hi @cnkLmxf!

Thanks for voicing your concern! It is understandable but the code is actually safe, however a little bit unclear.

The calculateChunkIndex method is called only from chunkIndex where it is guarded by if (isBaseTransform()) check.
Under the hood isBaseTransform() checks if the current enumeration is an instance of BaseTransformChunkEnumeration, so calculateChunkIndex is never called on encryption or compression enumerations. For BaseTransformChunkEnumeration, there's no size transformation, so transformedChunkSize equals originalChunkSize.

When encryption is enabled, the chunk index is built via nextElement which uses actual encrypted chunk sizes.