Skip to content

Fix silent err #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix silent err #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd547e
fix silent startup err
Almenon Nov 19, 2024
088e5e6
update error check
Almenon Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/PreviewManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export default class PreviewManager {
private warnIfOutdatedPythonVersion(pythonPath: string){
PythonShell.getVersion(`"${pythonPath}"`).then((out)=>{
let version = out.stdout ? out.stdout : out.stderr
if(version?.includes("Python 3.4") || version?.includes("Python 2")){
if(version?.includes("Python 2") || version?.includes("Python 3.4") || version?.includes("Python 3.5") || version?.includes("Python 3.6")){
vscode.window.showErrorMessage(`AREPL no longer supports ${version}.
Please upgrade or set AREPL.pythonPath to a diffent python.
AREPL needs python 3.7 or greater`)
Expand All @@ -199,9 +199,7 @@ export default class PreviewManager {
// if we get spawn error here thats already reported by telemetry
// so we skip telemetry reporting for this error
console.error(err)
if(err.message.includes("Python was not found but can be installed from the Microsoft Store")){
vscode.window.showErrorMessage(err.message)
}
vscode.window.showErrorMessage(err.message)
})
}

Expand Down