Feature/msi filetype

From GitbookIO#75

Author: rastiqdev

__tests__/platforms.js

@@ -17,6 +17,7 @@ describe("Platforms", function () {
       expect(platforms.detect("atom-1.0.9-delta.nupkg")).toEqual(
         platforms.WINDOWS_32,
       )
+      expect(platforms.detect("TestSetup.msi")).toEqual(platforms.WINDOWS_32)
       expect(platforms.detect("RELEASES")).toEqual(platforms.WINDOWS_32)
     })
 
@@ -205,6 +206,15 @@ describe("Platforms", function () {
               "https://api.github.com/repos/atom/atom/releases/assets/825728",
             download_count: 5612,
           },
+          {
+            type: "windows_32",
+            filename: "TestSetup.msi",
+            size: 78675700,
+            content_type: "application/x-msi",
+            download_url:
+              "https://api.github.com/repos/test/test2/releases/assets/7938398",
+            download_count: 1,
+          },
         ],
       }
 
@@ -248,6 +258,12 @@ describe("Platforms", function () {
             filePreference: [".zip"],
           }).filename,
         ).toEqual("test-3.3.1-darwin-x64.zip")
+
+        expect(
+          platforms.resolve(version, "win32", {
+            filePreference: [".msi"],
+          }).filename,
+        ).toEqual("TestSetup.msi")
       })
 
       test("should resolve to best platform with a wanted filetype", function () {

docs/assets.md

@@ -19,8 +19,8 @@ By default releases are tagged as 32-bits (except for OSX), but 64-bits will als
 Filetype and usage will be detected from the extension:
 
 | Platform | Extensions (sorted by priority)     |
-| -------- | ----------------------------------- |
-| Windows  | `.exe`, `.nupkg`, `.zip`            |
+|----------|-------------------------------------|
+| Windows  | `.exe`, `.nupkg`, `.zip`, `.msi`    |
 | OS X     | `.dmg`, `.zip`                      |
 | Linux    | `.AppImage`, `.deb`, `.rpm`, `.zip` |
 

docs/faq.md

@@ -20,7 +20,7 @@ Since version 3.0.0, Nuts can works with [other backends](https://github.com/Git
 
 Nuts can detect the type of file from its filename, there is no strict policy on file naming. Nuts tries to respect the filename/extension conventions for the different platforms. request:)
 
-- Windows: `.exe`, `.nupkg` etc
+- Windows: `.exe`, `.nupkg`, `.msi` etc
 - Linux: `.deb`, `.tar.gz`, etc
 - OS X: `.dmg`, etc
 

lib/utils/platforms.js

@@ -41,7 +41,11 @@ function detectPlatform(platform) {
     return platforms.WINDOWS_32
 
   // Detect prefix: osx, widnows or linux
-  if (_.includes(name, "win") || hasSuffix(name, ".exe"))
+  if (
+    _.includes(name, "win") ||
+    hasSuffix(name, ".exe") ||
+    hasSuffix(name, ".msi")
+  )
     prefix = platforms.WINDOWS
 
   if (
@@ -127,6 +131,7 @@ function resolveForVersion(version, platformID, opts) {
     // Order for filetype
     filePreference: [
       ".exe",
+      ".msi",
       ".dmg",
       ".AppImage",
       ".deb",