Skip to content

Conversation

@menisadi
Copy link
Contributor

📑 Description

Added zenbones colorscheme collection

📖 Additional Information

In order to prevent further dependencies I set the compatibility mode to 1.

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@menisadi menisadi changed the title Added Zeonbones colorscheme feat(colorscheme): add Zeonbones colorscheme Oct 19, 2025
@azdanov azdanov changed the title feat(colorscheme): add Zeonbones colorscheme feat(colorscheme): add zenbones colorscheme Oct 22, 2025
@menisadi
Copy link
Contributor Author

Thanks @Uzaaft
I pulled in your suggested edits and they look good.
I’ve synced my branch to include them.
Let me know if anything else is needed.

@Uzaaft
Copy link
Member

Uzaaft commented Oct 28, 2025

There is one missing thing, which is to configure the vim.g option with astrocore(I think its possible, tbh not 100% sure ,it has been a while since I looked at the docs so I gotta refrsh my memory first).

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the compat mode and added the deps. @menisadi Could you give this another test and we will merge after that

@menisadi
Copy link
Contributor Author

@Uzaaft thanks!!
Tested. Looks good to me :)
Working as expected.

@Uzaaft Uzaaft merged commit 46e2253 into AstroNvim:main Nov 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants