Merge pull request #193 from stanleysmall-microsoft/remove_serialization_trycatch

Remove trycatch from serialization methods

Author: stanleysmall-microsoft

src/RedisSessionStateProvider/RedisConnectionWrapper.cs

@@ -123,18 +123,11 @@ private bool SetPrepare(ISessionStateItemCollection data, int sessionTimeout, ou
 
         private byte[] SerializeSessionStateItemCollection(ISessionStateItemCollection sessionStateItemCollection)
         {
-            try
-            {
-                MemoryStream ms = new MemoryStream();
-                BinaryWriter writer = new BinaryWriter(ms);
-                ((SessionStateItemCollection)sessionStateItemCollection).Serialize(writer);
-                writer.Close();
-                return ms.ToArray();
-            }
-            catch
-            {
-                return null;
-            }
+            MemoryStream ms = new MemoryStream();
+            BinaryWriter writer = new BinaryWriter(ms);
+            ((SessionStateItemCollection)sessionStateItemCollection).Serialize(writer);
+            writer.Close();
+            return ms.ToArray();
         }
 
         public void Set(ISessionStateItemCollection data, int sessionTimeout)

src/Shared/StackExchangeClientConnection.cs

@@ -186,16 +186,9 @@ public ISessionStateItemCollection GetSessionData(object rowDataFromRedis)
 
         private SessionStateItemCollection DeserializeSessionStateItemCollection(RedisResult serializedSessionStateItemCollection)
         {
-            try
-            {
-                MemoryStream ms = new MemoryStream((byte[])serializedSessionStateItemCollection);
-                BinaryReader reader = new BinaryReader(ms);
-                return SessionStateItemCollection.Deserialize(reader);
-            }
-            catch
-            {
-                return null;
-            }
+            MemoryStream ms = new MemoryStream((byte[])serializedSessionStateItemCollection);
+            BinaryReader reader = new BinaryReader(ms);
+            return SessionStateItemCollection.Deserialize(reader);
         }
 
         public void Set(string key, byte[] data, DateTime utcExpiry)