> commit always fail (#8)

Author: muma378

cmd/main.go

@@ -184,12 +184,12 @@ func main() {
 				CAName:                "Webhook",
 				CAOrganization:        "SnapshotPod",
 				DNSName: fmt.Sprintf("%s.%s.svc", func() string {
-					return os.Getenv("MUTATE_WEBHOOK_NAME")
+					return os.Getenv("MUTATE_WEBHOOK_SVC_NAME")
 				}(), ns),
 				IsReady: ready,
 				Webhooks: []rotator.WebhookInfo{
 					{
-						Name: "snapshot-pod",
+						Name: os.Getenv("MUTATE_WEBHOOK_NAME"),
 						Type: rotator.Mutating,
 					},
 				},

go.mod

@@ -6,6 +6,7 @@ toolchain go1.22.2
 
 require (
 	github.com/containers/image/v5 v5.31.0
+	github.com/google/go-cmp v0.6.0
 	github.com/google/uuid v1.6.0
 	github.com/onsi/ginkgo/v2 v2.19.0
 	github.com/onsi/gomega v1.33.1
@@ -47,7 +48,6 @@ require (
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/google/gnostic-models v0.6.8 // indirect
-	github.com/google/go-cmp v0.6.0 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6 // indirect
 	github.com/gorilla/mux v1.8.1 // indirect

internal/controller/runtime/docker_compatible.go

@@ -31,8 +31,10 @@ func (d *dockerCompatibleRuntime) Commit(ctx context.Context, containerID, image
 	if author != "" {
 		args = append(args, "--author", author)
 	}
-	err := d.execCommand(ctx, args, nil)
-	return fmt.Errorf("commit failed: %w", err)
+	if err := d.execCommand(ctx, args, nil); err != nil {
+		return fmt.Errorf("commit image: %s", err)
+	}
+	return nil
 }
 
 func (d *dockerCompatibleRuntime) ImageExists(ctx context.Context, image string) bool {
@@ -67,16 +69,20 @@ func (d *dockerCompatibleRuntime) withLoginContextCommands(ctx context.Context,
 	if err != nil {
 		return err
 	}
-	err = d.execCommand(ctx, args, stdin)
-	return fmt.Errorf("encounter error after login: %w", err)
+	if err = d.execCommand(ctx, args, stdin); err != nil {
+		return fmt.Errorf("after login: %s", err)
+	}
+	return nil
 }
 
 func (d *dockerCompatibleRuntime) requireLogin(ctx context.Context, auth *Auth) error {
 	if auth == nil {
 		return nil
 	}
-	err := d.execCommand(ctx, []string{"login", auth.Registry}, nil)
-	return fmt.Errorf("login failed for: %w", err)
+	if err := d.execCommand(ctx, []string{"login", auth.Registry}, nil); err != nil {
+		return fmt.Errorf("login '%s': %s", auth.Registry, err)
+	}
+	return nil
 }
 
 func (d *dockerCompatibleRuntime) execCommand(ctx context.Context, args []string, stdin io.Reader) error {

manifests/snapshot-pod/templates/deployment.yaml

@@ -45,7 +45,10 @@ spec:
                   fieldPath: metadata.namespace
             - name: TLS_SECRET_NAME
               value: {{ include "snapshot-pod.fullname" . }}-tls
-            - name: MUTATE_WEBHOOK_NAME
+            # keep same with MutatingWebhookConfiguration name
+            - name: MUTATE_WEBHOOK_NAME 
+              value: {{ include "snapshot-pod.fullname" . }}
+            - name: MUTATE_WEBHOOK_SVC_NAME
               value: {{ include "snapshot-pod.fullname" . }}-webhook
           ports:
             - name: health