Move height changed signal/action into BasisLocalHeight

Basis/Packages/com.basis.framework/Camera/BasisHandHeldCameraInteractable.cs

@@ -161,7 +161,7 @@ public enum CameraPinSpace
         OnInteractStartEvent += OnInteractDesktopTweak;
         BasisDeviceManagement.OnBootModeChanged += OnBootModeChanged;
 
-        BasisLocalPlayer.OnPlayersHeightChangedNextFrame += OnHeightChanged;
+        BasisLocalHeight.OnHeightChangedNextFrame += OnHeightChanged;
 
         // scale camera to avatar size
         transform.localScale = new Vector3(cameraDefaultScale, cameraDefaultScale, cameraDefaultScale) *
@@ -623,7 +623,7 @@ public override void OnDestroy()
     {
         BasisDeviceManagement.OnBootModeChanged -= OnBootModeChanged;
         OnInteractStartEvent -= OnInteractDesktopTweak;
-        BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= OnHeightChanged;
+        BasisLocalHeight.OnHeightChangedNextFrame -= OnHeightChanged;
 
         BasisLocalPlayer.AfterFinalMove.RemoveAction(202, UpdateCamera);
 

Basis/Packages/com.basis.framework/Device Management/Common/BasisVisualTracker.cs

@@ -54,7 +54,7 @@ public void Initialization(BasisInput basisInput)
                 if (HasEvents == false)
                 {
                     BasisLocalPlayer.OnLocalAvatarChanged += UpdateVisualSizeAndOffset;
-                    BasisLocalPlayer.OnPlayersHeightChangedNextFrame += UpdateVisualSizeAndOffset;
+                    BasisLocalHeight.OnHeightChangedNextFrame += UpdateVisualSizeAndOffset;
                     HasEvents = true;
                 }
 
@@ -70,7 +70,7 @@ public void OnDestroy()
             if (HasEvents)
             {
                 BasisLocalPlayer.OnLocalAvatarChanged -= UpdateVisualSizeAndOffset;
-                BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= UpdateVisualSizeAndOffset;
+                BasisLocalHeight.OnHeightChangedNextFrame -= UpdateVisualSizeAndOffset;
                 HasEvents = false;
             }
         }

Basis/Packages/com.basis.framework/Drivers/Common/BasisHeightDriver.cs

@@ -28,7 +28,7 @@ public static class BasisHeightDriver
     /// <remarks>
     /// Establishes authoritative avatar metrics (eye height, arm span) first, then captures live player metrics.
     /// Ensures nonzero defaults, computes scale ratios safely, picks the active ratio set for <paramref name="selectedHeightMode"/>,
-    /// and invokes <see cref="BasisLocalPlayer.OnPlayersHeightChangedNextFrame"/> via <see cref="BasisLocalPlayer.ExecuteNextFrame(System.Action)"/>.
+    /// and invokes <see cref="BasisLocalHeight.OnHeightChangedNextFrame"/> via <see cref="BasisLocalPlayer.ExecuteNextFrame(System.Action)"/>.
     /// </remarks>
     public static void ChangeEyeHeightMode(BasisLocalPlayer localPlayer, BasisSelectedHeightMode selectedHeightMode)
     {
@@ -100,7 +100,7 @@ public static void ChangeEyeHeightMode(BasisLocalPlayer localPlayer, BasisSelect
         // notify next frame
         localPlayer.ExecuteNextFrame(() =>
         {
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke();
+            BasisLocalHeight.OnHeightChangedNextFrame?.Invoke();
         });
     }
 
@@ -254,7 +254,7 @@ public static void SetCustomPlayerHeight(float customHeight)
 
         player.ExecuteNextFrame(() =>
         {
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke();
+            BasisLocalHeight.OnHeightChangedNextFrame?.Invoke();
         });
     }
 }

Basis/Packages/com.basis.framework/Drivers/Local/BasisLocalCameraDriver.cs

@@ -187,7 +187,7 @@ public void OnEnable()
                 RenderPipelineManager.endCameraRendering += EndCameraRendering;
 
                 BasisDeviceManagement.OnBootModeChanged += OnModeSwitch;
-                BasisLocalPlayer.OnPlayersHeightChangedNextFrame += UpdateCameraScale;
+                BasisLocalHeight.OnHeightChangedNextFrame += UpdateCameraScale;
 
                 InstanceExists?.Invoke();
                 HasEvents = true;
@@ -216,7 +216,7 @@ public void OnDestroy()
             RenderPipelineManager.beginCameraRendering -= BeginCameraRendering;
             RenderPipelineManager.endCameraRendering -= EndCameraRendering;
             BasisDeviceManagement.OnBootModeChanged -= OnModeSwitch;
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= UpdateCameraScale;
+            BasisLocalHeight.OnHeightChangedNextFrame -= UpdateCameraScale;
             BasisLocalMicrophoneDriver.OnPausedAction -= microphoneIconDriver.OnPausedEvent;
             HasEvents = false;
             HasInstance = false;

Basis/Packages/com.basis.framework/Drivers/Local/BasisLocalSeatDriver.cs

@@ -120,7 +120,7 @@ public void Sit(BasisSeat seat)
             GrabLatestTposeLocalScaleData();
             if (hasEvent == false)
             {
-                BasisLocalPlayer.OnPlayersHeightChangedNextFrame += GrabLatestTposeLocalScaleData;
+                BasisLocalHeight.OnHeightChangedNextFrame += GrabLatestTposeLocalScaleData;
                 hasEvent = true;
             }
             OnSimulate();
@@ -156,7 +156,7 @@ public void Stand()
             GrabLatestTposeLocalScaleData();
             if (hasEvent)
             {
-                BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= GrabLatestTposeLocalScaleData;
+                BasisLocalHeight.OnHeightChangedNextFrame -= GrabLatestTposeLocalScaleData;
                 hasEvent = false;
             }
             _seat = null;
@@ -299,7 +299,6 @@ Quaternion rightLowerLegRot
             Vector3 playerPelvisLocalPos = 0.5f * (BasisLocalBoneDriver.LeftUpperLegControl.TposeLocalScaled.position + BasisLocalBoneDriver.RightUpperLegControl.TposeLocalScaled.position);
             Vector3 playerPos = pelvisWorldPos - playerRot * playerPelvisLocalPos;
 
-
             LocalPlayer.transform.SetPositionAndRotation(playerPos, playerRot);
            //dont need todo this LocalPlayer.AvatarTransform.SetPositionAndRotation(playerPos, playerRot);
             LocalPlayer.LocalAnimatorDriver.HandleTeleport();

Basis/Packages/com.basis.framework/Players/Local/BasisLocalHeight.cs

@@ -26,6 +26,11 @@ public class BasisLocalHeight
         /// </summary>
         public string AvatarName;
 
+        /// <summary>
+        /// Fired on the frame after a player height change is requested.
+        /// </summary>
+        public static System.Action OnHeightChangedNextFrame;
+
         /// <summary>
         /// Fallback height (meters) used when no measurement is available.
         /// not the total height but the eye height

Basis/Packages/com.basis.framework/Players/Local/BasisLocalPlayer.cs

@@ -77,11 +77,6 @@ public class BasisLocalPlayer : BasisPlayer
         /// </summary>
         public static Action OnSpawnedEvent;
 
-        /// <summary>
-        /// Fired on the frame after a player height change is requested.
-        /// </summary>
-        public static Action OnPlayersHeightChangedNextFrame;
-
         /// <summary>
         /// Ordered delegate queue invoked after all movement and simulation have completed for the frame.
         /// </summary>

Basis/Packages/com.basis.framework/UI Panels/BasisSetUserName.cs

@@ -82,7 +82,7 @@ public void Start()
             }
 
             ApplySize();
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame += ApplySize;
+            BasisLocalHeight.OnHeightChangedNextFrame += ApplySize;
             if (BasisNetworkManagement.Instance != null)
             {
                 LoadCurrentSettings();
@@ -110,7 +110,7 @@ public void OnDestroy()
                 AdvancedSettings.onClick.RemoveListener(ToggleAdvancedSettings);
                 UseLocalhost.onClick.RemoveListener(UseLocalHost);
             }
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= ApplySize;
+            BasisLocalHeight.OnHeightChangedNextFrame -= ApplySize;
         }
 
         /// <summary>

Basis/Packages/com.basis.framework/UI Panels/BasisUIMovementDriver.cs

@@ -46,7 +46,7 @@ public void DeInitalize()
                 BasisLocalPlayer.AfterFinalMove.RemoveAction(120, UpdateUIFollow);
             }
 
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= SetUILocation;
+            BasisLocalHeight.OnHeightChangedNextFrame -= SetUILocation;
 
             if (hasLocalCreationEvent)
             {
@@ -60,7 +60,7 @@ public void LocalPlayerGenerated()
             {
                 BasisLocalPlayer.AfterFinalMove.AddAction(120, UpdateUIFollow);
             }
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame += SetUILocation;
+            BasisLocalHeight.OnHeightChangedNextFrame += SetUILocation;
             SetUILocation();
         }
         public void UpdateUIFollow()

Basis/Packages/com.basis.framework/UI Panels/BasisUIServers.cs

@@ -53,7 +53,7 @@ public void Start()
             }
             UseLocalhost.onClick.AddListener(UseLocalHost);
             ApplySize();
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame += ApplySize;
+            BasisLocalHeight.OnHeightChangedNextFrame += ApplySize;
             if (BasisNetworkManagement.Instance != null)
             {
                 LoadCurrentSettings();
@@ -68,7 +68,7 @@ public void ApplySize()
         }
         public void OnDestroy()
         {
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= ApplySize;
+            BasisLocalHeight.OnHeightChangedNextFrame -= ApplySize;
             UseLocalhost.onClick.RemoveListener(UseLocalHost);
         }
         public void UseHostMode(bool IsDown)

Basis/Packages/com.basis.framework/UI/BasisMenuMovementDriver.cs

@@ -49,7 +49,7 @@ private void OnDisable()
             }
 
             BasisLocalPlayer.OnLocalAvatarChanged -= UpdateDelayedSetUI;
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= UpdateDelayedSetUI;
+            BasisLocalHeight.OnHeightChangedNextFrame -= UpdateDelayedSetUI;
 
             BasisLocalPlayer.AfterFinalMove.RemoveAction(101, UpdateUI);
         }
@@ -59,7 +59,7 @@ private void OnDisable()
         private void OnLocalPlayerGenerated()
         {
             BasisLocalPlayer.OnLocalAvatarChanged += UpdateDelayedSetUI;
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame += UpdateDelayedSetUI;
+            BasisLocalHeight.OnHeightChangedNextFrame += UpdateDelayedSetUI;
             if (LocalPlayer.LocalBoneDriver.FindBone(out hand, BasisBoneTrackedRole.LeftHand))
             {
             }

Basis/Packages/com.basis.framework/UI/BasisUIRaycast.cs

@@ -70,7 +70,7 @@ public void Initialize(BasisInput basisInput, BasisPointRaycaster pointRaycaster
 
             HasLineRenderer = false;
             HasRedicalRenderer = false;
-            BasisLocalPlayer.OnPlayersHeightChangedNextFrame += OnPlayersHeightChanged;
+            BasisLocalHeight.OnHeightChangedNextFrame += OnPlayersHeightChanged;
             // Create the ray with the adjusted starting position and direction
             if (basisInput.DeviceMatchSettings.HasRayCastVisual)
             {
@@ -119,7 +119,7 @@ public void OnDeInitialize()
         {
             if (HasOnPlayersHeightChanged)
             {
-                BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= OnPlayersHeightChanged;
+                BasisLocalHeight.OnHeightChangedNextFrame -= OnPlayersHeightChanged;
             }
         }