Skip to content

Conversation

@kashif
Copy link

@kashif kashif commented Dec 19, 2023

also fixed a bug due to this in MishGLU

@BlinkDL
Copy link
Owner

BlinkDL commented Dec 20, 2023

these parameters are trainable
so we use nn.Parameter

@kashif
Copy link
Author

kashif commented Dec 20, 2023

ah ok then what does the with torch.no_grad(): do?

@kashif
Copy link
Author

kashif commented Dec 29, 2023

@BlinkDL happy to close this PR or should i remove the torch.no_grad()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants