Fix GitHub Copilot reasoning_effort parameter format for GPT-5 models #11141
+226
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Copilot was not passing the
reasoning_effortparameter for GPT-5/o1/o3/o4 thinking models. The parameter was being sent in a deprecated format that the OpenAI SDK silently discards.Root Cause
OpenAIAPIClient.getReasoningEffort()returned{ reasoning_effort: "medium" }for all reasoning models. Per SDK type definitions,reasoning_effortis deprecated for OpenAI-compatible providers and gets overwritten toundefined.Changes
Production code (7 lines):
isSupportedReasoningEffortOpenAIModel()OpenAIBaseClient.getReasoningEffort()which returns correct{ reasoning: { effort, summary } }formatreasoning_effortparameterTest coverage:
Impact
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.sheetjs.com/usr/local/bin/node /home/REDACTED/work/cherry-studio/cherry-studio/.yarn/releases/yarn-4.9.1.cjs install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.