Add logging (#72)

* Add additional settings config check

* Add helper class for getting underlying http handler

* Add logging to Connection, Command, and BulkCopy

* Add logging example

Author: alex-clickhouse

.editorconfig

@@ -26,6 +26,7 @@ dotnet_diagnostic.SA1602.severity = none # SA1602: Enumeration items should be d
 dotnet_diagnostic.SA1629.severity = none # SA1629: Documentation text should end with a period
 dotnet_diagnostic.SA1633.severity = none # SA1633: File should have header
 
+dotnet_diagnostic.CA1848.severity = suggestion # CA1848: Use the LoggerMessage delegates
 dotnet_diagnostic.SA1201.severity = suggestion # SA1201: Elements should appear in the correct order
 dotnet_diagnostic.SA1202.severity = suggestion # SA1202: Elements should be ordered by access
 dotnet_diagnostic.SA1204.severity = suggestion # SA1204: Static elements should appear before instance elements

ClickHouse.Driver.Tests/ADO/ClickHouseClientSettingsTests.cs

@@ -265,6 +265,19 @@ public void Validate_WithUseSessionAndHttpClient_ShouldThrow()
         Assert.That(ex.Message, Does.Contain("UseSession cannot be combined with a custom HttpClient"));
     }
 
+    [Test]
+    public void Validate_WithUseSessionAndHttpClientFactory_ShouldThrow()
+    {
+        var settings = new ClickHouseClientSettings
+        {
+            UseSession = true,
+            HttpClientFactory = new TestHttpClientFactory()
+        };
+
+        var ex = Assert.Throws<InvalidOperationException>(() => settings.Validate());
+        Assert.That(ex.Message, Does.Contain("UseSession cannot be combined with a custom HttpClientFactory"));
+    }
+
     [Test]
     public void Validate_WithBothHttpClientAndFactory_ShouldThrow()
     {

ClickHouse.Driver.Tests/ADO/ClickHouseCommandTests.cs

@@ -0,0 +1,70 @@
+using System;
+using ClickHouse.Driver.ADO;
+namespace ClickHouse.Driver.Tests.ADO;
+
+public class ClickHouseCommandTests
+{
+    [Test]
+    public void ExecuteReaderAsync_WithoutConnection_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var command = new ClickHouseCommand();
+        command.CommandText = "SELECT 1";
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            using var reader = await command.ExecuteReaderAsync();
+        });
+
+        Assert.That(ex.Message, Is.EqualTo("Connection is not set"));
+    }
+
+    [Test]
+    public void ExecuteNonQueryAsync_WithoutConnection_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var command = new ClickHouseCommand();
+        command.CommandText = "INSERT INTO test VALUES (1)";
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            await command.ExecuteNonQueryAsync();
+        });
+
+        Assert.That(ex.Message, Is.EqualTo("Connection is not set"));
+    }
+
+    [Test]
+    public void ExecuteScalarAsync_WithoutConnection_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var command = new ClickHouseCommand();
+        command.CommandText = "SELECT 1";
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            await command.ExecuteScalarAsync();
+        });
+
+        Assert.That(ex.Message, Is.EqualTo("Connection is not set"));
+    }
+
+    [Test]
+    public void ExecuteRawResultAsync_WithoutConnection_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var command = new ClickHouseCommand();
+        command.CommandText = "SELECT 1 FORMAT JSON";
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            await command.ExecuteRawResultAsync(default);
+        });
+
+        Assert.That(ex.Message, Is.EqualTo("Connection is not set"));
+    }
+}

ClickHouse.Driver.Tests/BulkCopy/BulkCopyTests.cs

@@ -529,5 +529,49 @@ data Tuple(name String, status Enum8('Active' = 0, 'Inactive' = 1))
 
         Assert.That(bulkCopy.RowsWritten, Is.EqualTo(2));
     }
+    
+    [Test]
+    public void InitAsync_WithNullDestinationTableName_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var settings = new ClickHouseClientSettings(TestUtilities.GetConnectionStringBuilder());
+
+        using var connection = new ClickHouseConnection(settings);
+        var bulkCopy = new ClickHouseBulkCopy(connection)
+        {
+            DestinationTableName = null,  // Not set
+        };
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            await bulkCopy.InitAsync();
+        });
+
+        Assert.That(ex.Message, Does.Contain("DestinationTableName"));
+    }
+
+    [Test]
+    public void WriteToServerAsync_WithNullDestinationTableName_ThrowsInvalidOperationException()
+    {
+        // Arrange
+        var settings = new ClickHouseClientSettings(TestUtilities.GetConnectionStringBuilder());
+
+        using var connection = new ClickHouseConnection(settings);
+        var bulkCopy = new ClickHouseBulkCopy(connection)
+        {
+            DestinationTableName = null,  // Not set
+        };
+
+        var rows = new List<object[]> { new object[] { 1, "test" } };
+
+        // Act & Assert
+        var ex = Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        {
+            await bulkCopy.WriteToServerAsync(rows);
+        });
+
+        Assert.That(ex.Message, Does.Contain("Destination table not set"));
+    }
 }
 

ClickHouse.Driver.Tests/Http/HttpClientHelpersTests.cs

@@ -0,0 +1,78 @@
+using System.Net.Http;
+using ClickHouse.Driver.Http;
+using NUnit.Framework;
+
+namespace ClickHouse.Driver.Tests.Http;
+
+public class HttpClientExtensionsTests
+{
+    [Test]
+    public void GetHandler_ReturnsHandlerForDefaultHttpClient()
+    {
+        using var httpClient = new HttpClient();
+
+        var handler = httpClient.GetHandler();
+
+        Assert.That(handler, Is.Not.Null);
+        // Default HttpClient always creates SocketsHttpHandler on .NET 5+
+#if NET5_0_OR_GREATER
+        Assert.That(handler, Is.InstanceOf<SocketsHttpHandler>());
+#else
+        Assert.That(handler, Is.InstanceOf<HttpClientHandler>());
+#endif
+    }
+
+#if NET5_0_OR_GREATER
+    [Test]
+    public void GetHandler_ReturnsProvidedSocketsHttpHandler()
+    {
+        var handler = new SocketsHttpHandler();
+        using var httpClient = new HttpClient(handler, disposeHandler: false);
+
+        var retrievedHandler = httpClient.GetHandler();
+
+        Assert.That(retrievedHandler, Is.SameAs(handler));
+        Assert.That(retrievedHandler, Is.InstanceOf<SocketsHttpHandler>());
+    }
+
+
+    [Test]
+    public void GetHandler_RetrievesHttpClientHandlerConfiguration()
+    {
+        var handler = new HttpClientHandler
+        {
+            MaxConnectionsPerServer = 42,
+            AllowAutoRedirect = false,
+            UseCookies = false
+        };
+        using var httpClient = new HttpClient(handler, disposeHandler: false);
+
+        var retrievedHandler = httpClient.GetHandler() as SocketsHttpHandler;
+
+        Assert.That(retrievedHandler, Is.Not.Null);
+        Assert.That(retrievedHandler.MaxConnectionsPerServer, Is.EqualTo(42));
+        Assert.That(retrievedHandler.AllowAutoRedirect, Is.False);
+        Assert.That(retrievedHandler.UseCookies, Is.False);
+    }
+
+
+    [Test]
+    public void GetHandler_RetrievesSocketsHttpHandlerConfiguration()
+    {
+        var handler = new SocketsHttpHandler
+        {
+            MaxConnectionsPerServer = 100,
+            AllowAutoRedirect = true,
+            UseCookies = false
+        };
+        using var httpClient = new HttpClient(handler, disposeHandler: false);
+
+        var retrievedHandler = httpClient.GetHandler() as SocketsHttpHandler;
+
+        Assert.That(retrievedHandler, Is.Not.Null);
+        Assert.That(retrievedHandler.MaxConnectionsPerServer, Is.EqualTo(100));
+        Assert.That(retrievedHandler.AllowAutoRedirect, Is.True);
+        Assert.That(retrievedHandler.UseCookies, Is.False);
+    }
+#endif
+}