Refactor spawn state to an enum

Author: SupremeMortal

bedrock/bedrock-common/src/main/java/com/nukkitx/protocol/bedrock/packet/RespawnPacket.java

@@ -10,11 +10,17 @@
 @EqualsAndHashCode(callSuper = true)
 public class RespawnPacket extends BedrockPacket {
     private Vector3f position;
-    private int spawnState; // 0 server searching, 1 server ready, 3 client ready (server bound)
+    private State spawnState;
     private long runtimeEntityId; // Only used server bound and pretty pointless
 
     @Override
     public final boolean handle(BedrockPacketHandler handler) {
         return handler.handle(this);
     }
+
+    public enum State {
+        SERVER_SEARCHING,
+        SERVER_READY,
+        CLIENT_READY
+    }
 }

bedrock/bedrock-v388/src/main/java/com/nukkitx/protocol/bedrock/v388/serializer/RespawnSerializer_v388.java

@@ -12,18 +12,19 @@
 public class RespawnSerializer_v388 implements PacketSerializer<RespawnPacket> {
     public static final RespawnSerializer_v388 INSTANCE = new RespawnSerializer_v388();
 
+    private static final RespawnPacket.State[] VALUES = RespawnPacket.State.values();
 
     @Override
     public void serialize(ByteBuf buffer, RespawnPacket packet) {
         BedrockUtils.writeVector3f(buffer, packet.getPosition());
-        buffer.writeByte(packet.getSpawnState());
+        buffer.writeByte(packet.getSpawnState().ordinal());
         VarInts.writeUnsignedLong(buffer, packet.getRuntimeEntityId());
     }
 
     @Override
     public void deserialize(ByteBuf buffer, RespawnPacket packet) {
         packet.setPosition(BedrockUtils.readVector3f(buffer));
-        packet.setSpawnState(buffer.readUnsignedByte());
+        packet.setSpawnState(VALUES[buffer.readUnsignedByte()]);
         packet.setRuntimeEntityId(VarInts.readUnsignedLong(buffer));
     }
 }