test correlations of lsp/rsp and rw/rsp #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
We should also test if changes in theta increase the similarity as expected. Another possibility is to try Float128 for better accuracity solves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the correlation between LeastCostPath and RSP with high theta, and RandomWalk/RSP with low theta.
@ninbrm this will need your input as to whether this makes sense, but it seems like a fairly intuitive way to explicitly link and test the three approaches.
The betweenness measures dont end up exactly the same. The correlation increasese as theta gets lower/higher but the overall magnitudes dont necessarily match. Thats why
coris used rather thanisapprox.On the LCP / RSP high theta side things start to break with NaNs and other kinds of overflow as theta gets too high, so we can't test all the outputs.
Another consideration is we should test it accross distance_transformation values, like
alpha=2.0, as the correlation seems to drop off a lot.