refactor: remove batch_mode and locale from configuration

Author: Cyber-Syntax

docs/architecture/configuration.md

@@ -41,8 +41,6 @@ Default values and where they are defined
 config_version = 1.0.0
 max_concurrent_downloads = 5
 max_backup = 1
-batch_mode = true
-locale = en_US
 log_level = INFO
 console_log_level = WARNING
 [network]

docs/wiki.md

@@ -218,13 +218,6 @@ max_concurrent_downloads = 5
 # Maximum number of backups to keep for each AppImage.
 max_backup = 1
 
-# Enables batch mode for downloading AppImages without user interaction.
-batch_mode = true
-
-# Locale for the user interface and messages.
-# Supported languages: English (en_US)
-locale = "en_US"
-
 # Logging level for the application.
 # Supported levels: DEBUG, INFO, WARNING, ERROR
 log_level = "INFO"

my_unicorn/commands/config.py

@@ -26,8 +26,9 @@ async def _show_config(self) -> None:
         """Display current configuration."""
         print("📋 Current Configuration:")
         print(f"  Config Version: {self.global_config['config_version']}")
-        print(f"  Max Downloads: {self.global_config['max_concurrent_downloads']}")
-        print(f"  Batch Mode: {self.global_config['batch_mode']}")
+        print(
+            f"  Max Downloads: {self.global_config['max_concurrent_downloads']}"
+        )
         print(f"  Log Level: {self.global_config['log_level']}")
         print(f"  Storage Dir: {self.global_config['directory']['storage']}")
         print(f"  Download Dir: {self.global_config['directory']['download']}")

my_unicorn/config.py

@@ -24,19 +24,15 @@
     CONFIG_FILE_NAME,
     CONFIG_VERSION,
     DEFAULT_APPS_DIR_NAME,
-    DEFAULT_BATCH_MODE,
     DEFAULT_CONFIG_SUBDIR,
     DEFAULT_CONSOLE_LOG_LEVEL,
-    DEFAULT_LOCALE,
     DEFAULT_LOG_LEVEL,
     DEFAULT_MAX_BACKUP,
     DEFAULT_MAX_CONCURRENT_DOWNLOADS,
     DIRECTORY_KEYS,
     ISO_DATETIME_FORMAT,
-    KEY_BATCH_MODE,
     KEY_CONFIG_VERSION,
     KEY_CONSOLE_LOG_LEVEL,
-    KEY_LOCALE,
     KEY_LOG_LEVEL,
     KEY_MAX_BACKUP,
     KEY_MAX_CONCURRENT_DOWNLOADS,
@@ -96,8 +92,6 @@ def get_section_comments() -> dict[str, str]:
 # config_version: Version of configuration format (DO NOT EDIT)
 # max_concurrent_downloads: Max simultaneous downloads (1-10)
 # max_backup: Number of backup copies to keep when updating apps (0-5)
-# batch_mode: Enable non-interactive mode (true/false)
-# locale: Language setting (en_US, es_ES, fr_FR, etc.)
 # log_level: Detail level for log files (DEBUG, INFO, WARNING, ERROR)
 # console_log_level: Console output detail level (DEBUG, INFO, etc.)
 
@@ -178,8 +172,6 @@ class GlobalConfig(TypedDict):
     config_version: str
     max_concurrent_downloads: int
     max_backup: int
-    batch_mode: bool
-    locale: str
     log_level: str
     console_log_level: str
     network: NetworkConfig
@@ -384,8 +376,6 @@ def get_default_global_config(self) -> dict[str, str | dict[str, str]]:
                 DEFAULT_MAX_CONCURRENT_DOWNLOADS
             ),
             KEY_MAX_BACKUP: str(DEFAULT_MAX_BACKUP),
-            KEY_BATCH_MODE: str(DEFAULT_BATCH_MODE).lower(),
-            KEY_LOCALE: DEFAULT_LOCALE,
             KEY_LOG_LEVEL: DEFAULT_LOG_LEVEL,
             KEY_CONSOLE_LOG_LEVEL: DEFAULT_CONSOLE_LOG_LEVEL,
             SECTION_NETWORK: {"retry_attempts": "3", "timeout_seconds": "10"},
@@ -507,8 +497,6 @@ def save_global_config(self, config: GlobalConfig) -> None:
                     config["max_concurrent_downloads"]
                 ),
                 "max_backup": str(config["max_backup"]),
-                "batch_mode": str(config["batch_mode"]).lower(),
-                "locale": config["locale"],
                 "log_level": config["log_level"],
                 "console_log_level": config["console_log_level"],
             }
@@ -640,14 +628,6 @@ def get_scalar_config(key: str, default: str | int) -> str | int:
             else 10,
         )
 
-        # Get batch mode value
-        batch_mode_str = get_scalar_config("batch_mode", "true")
-        batch_mode = (
-            batch_mode_str.lower() == "true"
-            if isinstance(batch_mode_str, str)
-            else True
-        )
-
         return GlobalConfig(
             config_version=str(
                 get_scalar_config("config_version", CONFIG_VERSION)
@@ -656,8 +636,6 @@ def get_scalar_config(key: str, default: str | int) -> str | int:
                 get_scalar_config("max_concurrent_downloads", 5)
             ),
             max_backup=int(get_scalar_config("max_backup", 1)),
-            batch_mode=batch_mode,
-            locale=str(get_scalar_config("locale", "en_US")),
             log_level=str(get_scalar_config("log_level", "INFO")),
             console_log_level=str(
                 get_scalar_config("console_log_level", "WARNING")

my_unicorn/constants.py

@@ -36,8 +36,6 @@
 # Defaults used by the global config manager
 DEFAULT_MAX_CONCURRENT_DOWNLOADS: Final[int] = 5
 DEFAULT_MAX_BACKUP: Final[int] = 1
-DEFAULT_BATCH_MODE: Final[bool] = True
-DEFAULT_LOCALE: Final[str] = "en_US"
 DEFAULT_CONSOLE_LOG_LEVEL: Final[str] = "WARNING"
 
 # Date/time formats used in config headers and saved timestamps
@@ -51,8 +49,6 @@
 KEY_CONFIG_VERSION: Final[str] = "config_version"
 KEY_MAX_CONCURRENT_DOWNLOADS: Final[str] = "max_concurrent_downloads"
 KEY_MAX_BACKUP: Final[str] = "max_backup"
-KEY_BATCH_MODE: Final[str] = "batch_mode"
-KEY_LOCALE: Final[str] = "locale"
 KEY_LOG_LEVEL: Final[str] = "log_level"
 KEY_CONSOLE_LOG_LEVEL: Final[str] = "console_log_level"
 

scripts/update.bash

@@ -4,13 +4,6 @@
 # in the ~/.config/my-unicorn/apps directory.
 # You need to install the apps first to use this script.
 #
-# Make sure you enabled batch mode if you want to run this
-# script in an automated fashion (e.g. via cron or a window
-# manager autostart). Batch mode already defaults to true
-# in the ~/.config/my-unicorn/settings.conf file.
-#
-#   "batch_mode": true,
-#
 # Author: Cyber-Syntax
 # License: same as my-unicorn project
 

tests/commands/test_config.py

@@ -40,7 +40,6 @@ def load_global_config(self):
             return {
                 "config_version": "1.0",
                 "max_concurrent_downloads": 5,
-                "batch_mode": True,
                 "log_level": "INFO",
                 "directory": {
                     "storage": "/tmp/storage",
@@ -77,7 +76,7 @@ async def test_execute_show(monkeypatch, handler, capsys):
     assert "📋 Current Configuration:" in captured.out
     assert "Config Version: 1.0" in captured.out
     assert "Max Downloads: 5" in captured.out
-    assert "Batch Mode: True" in captured.out
+
     assert "Log Level: INFO" in captured.out
     assert "/tmp/storage" in captured.out
     assert "/tmp/download" in captured.out

tests/test_config.py

@@ -206,8 +206,6 @@ def test_ensure_directories_from_config(config_manager, tmp_path):
         "config_version": "1.0.0",
         "max_concurrent_downloads": 5,
         "max_backup": 1,
-        "batch_mode": True,
-        "locale": "en_US",
         "log_level": "INFO",
         "network": {"retry_attempts": 3, "timeout_seconds": 10},
         "directory": dirs,
@@ -288,7 +286,6 @@ def test_comment_stripping_configparser(config_manager):
     """Test that CommentAwareConfigParser correctly strips inline comments."""
     # Create a config file with inline comments
     config_content = """[DEFAULT]
-batch_mode = true  # Non-interactive mode
 
 [directory]
 logs = /test/logs  # Log files directory
@@ -305,7 +302,6 @@ def test_comment_stripping_configparser(config_manager):
     parser.read(test_config_file)
 
     # Verify that comments are stripped from values
-    assert parser.get("DEFAULT", "batch_mode") == "true"
     assert parser.get("directory", "logs") == "/test/logs"
     assert parser.get("directory", "cache") == "/test/cache"
     assert parser.get("directory", "tmp") == "/test/tmp"
@@ -369,7 +365,6 @@ def test_global_config_manager(config_dir):
     raw_config = ConfigParser()
     raw_config.add_section("settings")
     raw_config.set("settings", "max_backup", "3")
-    raw_config.set("settings", "locale", "en_US")
     converted = global_manager._convert_to_global_config(raw_config)
     assert "directory" in converted
     assert "network" in converted
@@ -580,7 +575,7 @@ def test_config_manager_facade_integration(config_dir):
     assert isinstance(default_config, dict)
 
     # Test the global config manager conversion method by creating a proper config dict
-    test_config = {"max_backup": "2", "locale": "en_US", "directory": {}}
+    test_config = {"max_backup": "2", "directory": {}}
     converted_config = (
         config_manager.global_config_manager._convert_to_global_config(
             test_config
@@ -661,7 +656,6 @@ def test_merge_missing_fields(config_dir):
     # Start with minimal config using proper ConfigParser syntax
     user_config.read_string("""[DEFAULT]
 config_version = 1.0.0
-locale = en_US
 """)
 
     defaults = manager.get_default_global_config()
@@ -740,7 +734,6 @@ def test_configuration_migration_integration(config_dir):
     # Create old configuration file missing some fields
     old_config_content = """[DEFAULT]
 config_version = 1.0.0
-locale = fr_FR
 max_backup = 3
 
 [network]
@@ -756,7 +749,6 @@ def test_configuration_migration_integration(config_dir):
 
     # Verify configuration was migrated
     assert config["config_version"] == "1.0.2"  # Should be updated
-    assert config["locale"] == "fr_FR"  # User value preserved
     assert config["max_backup"] == 3  # User value preserved
     assert config["network"]["retry_attempts"] == 5  # User value preserved
 
@@ -791,7 +783,6 @@ def mock_validate_failure(config):
 
     old_config_content = """[DEFAULT]
 config_version = 1.0.0
-locale = test_locale
 """
     manager.directory_manager.settings_file.write_text(old_config_content)
 
@@ -817,7 +808,6 @@ def test_migration_with_new_config_file(config_dir):
 
     # Should create default configuration
     assert config["config_version"] == "1.0.2"
-    assert config["locale"] == "en_US"
     assert manager.directory_manager.settings_file.exists()
 
 
@@ -827,30 +817,28 @@ def test_migration_no_changes_needed(config_dir):
 
     # Create current configuration file with all required fields
     complete_config_content = """[DEFAULT]
-config_version = 1.0.2
-max_concurrent_downloads = 5
-max_backup = 1
-batch_mode = true
-locale = en_US
-log_level = INFO
-console_log_level = WARNING
-
-[network]
-retry_attempts = 3
-timeout_seconds = 10
-
-[directory]
-repo = /tmp/test-repo
-package = /tmp/test-package
-download = /tmp/downloads
-storage = /tmp/storage
-backup = /tmp/backup
-icon = /tmp/icons
-settings = /tmp/settings
-logs = /tmp/logs
-cache = /tmp/cache
-tmp = /tmp/tmp
-"""
+    config_version = 1.0.2
+    max_concurrent_downloads = 5
+    max_backup = 1
+    log_level = INFO
+    console_log_level = WARNING
+
+    [network]
+    retry_attempts = 3
+    timeout_seconds = 10
+
+    [directory]
+    repo = /tmp/test-repo
+    package = /tmp/test-package
+    download = /tmp/downloads
+    storage = /tmp/storage
+    backup = /tmp/backup
+    icon = /tmp/icons
+    settings = /tmp/settings
+    logs = /tmp/logs
+    cache = /tmp/cache
+    tmp = /tmp/tmp
+    """
 
     manager.directory_manager.settings_file.write_text(complete_config_content)
 
@@ -915,7 +903,6 @@ def test_comment_stripping_functionality(config_dir, tmp_path):
     config_content = """[DEFAULT]
 max_concurrent_downloads = 10  # Max simultaneous downloads
 max_backup = 3  # Number of backup copies to keep
-batch_mode = false  # Non-interactive mode
 
 [network]
 retry_attempts = 5  # Download retry attempts
@@ -932,7 +919,6 @@ def test_comment_stripping_functionality(config_dir, tmp_path):
 
     assert config["max_concurrent_downloads"] == 10
     assert config["max_backup"] == 3
-    assert config["batch_mode"] is False
     assert config["network"]["retry_attempts"] == 5
     assert config["network"]["timeout_seconds"] == 30
     assert str(config["directory"]["download"]) == "/tmp/downloads"