feat: add icon extraction feature (#192)

Author: Cyber-Syntax

CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## v1.2.0-alpha
+### CHANGES
+This release implement new icon extraction feature and implement new verfication service.
+
+
 ## v1.1.3-alpha
 ## v1.1.2-alpha
 ## v1.1.0-alpha

docs/wiki.md

@@ -61,6 +61,7 @@ my-unicorn list --available
 
 # Remove apps
 my-unicorn remove appflowy --keep-config
+my-unicorn remove appflowy qownotes 
 
 # Show configuration
 my-unicorn config --show

my_unicorn/catalog/dummyapp.json

@@ -4,9 +4,7 @@
     "appimage": {
         "rename": "qownnotes",
         "name_template": "{repo}-{characteristic_suffix}.AppImage",
-        "characteristic_suffix": [
-            "x86_64.AppImage"
-        ]
+        "characteristic_suffix": ["x86_64.AppImage"]
     },
     "github": {
         "repo": true,
@@ -20,6 +18,7 @@
     },
     "icon": {
         "url": "https://raw.githubusercontent.com/pbek/QOwnNotes/develop/icons/icon.png",
-        "name": "qownnotes.png"
+        "name": "qownnotes.png",
+        "extraction": true
     }
-}
+}

my_unicorn/catalog/qownnotes.json

@@ -287,7 +287,7 @@ async def _handle_cleanup(self, app_name: str | None = None) -> None:
                 print(f"✅ Cleanup completed (keeping {max_backups} most recent backups)")
 
         except Exception as e:
-            logger.error(f"❌ Failed to cleanup backups: {e}")
+            logger.error("❌ Failed to cleanup backups: %s", e)
 
     async def _handle_info(self, app_name: str) -> None:
         """Handle show backup info operation.
@@ -343,7 +343,7 @@ async def _handle_info(self, app_name: str) -> None:
             print(f"  🔄 Max backups kept: {max_backups if max_backups > 0 else 'unlimited'}")
 
         except Exception as e:
-            logger.error(f"❌ Failed to get backup info for {app_name}: {e}")
+            logger.error("❌ Failed to get backup info for %s: %s", app_name, e)
 
     async def _handle_migrate(self) -> None:
         """Handle migration of old backup format."""
@@ -358,4 +358,4 @@ async def _handle_migrate(self) -> None:
                 print("ℹ️  No old backup files found to migrate")
 
         except Exception as e:
-            logger.error(f"❌ Failed to migrate old backups: {e}")
+            logger.error("❌ Failed to migrate old backups: %s", e)

my_unicorn/commands/backup.py

@@ -96,13 +96,13 @@ async def execute(self, targets: list[str], **options: Any) -> list[dict[str, An
         if not targets:
             raise ValidationError("No installation targets provided")
 
-        logger.info(f"🚀 Starting installation of {len(targets)} target(s)")
+        logger.info("🚀 Starting installation of %d target(s)", len(targets))
 
         # Separate targets into URLs and catalog apps
         url_targets, catalog_targets = self._separate_targets(targets)
 
         # Prepare options with defaults
-        #TODO: use the global setting for the concurrent option
+        # TODO: use the global setting for the concurrent option
         install_options = {
             "concurrent": options.get("concurrent", 3),
             "show_progress": options.get("show_progress", True),
@@ -115,12 +115,12 @@ async def execute(self, targets: list[str], **options: Any) -> list[dict[str, An
         results = []
 
         if url_targets:
-            logger.info(f"📡 Installing {len(url_targets)} URL(s)")
+            logger.info("📡 Installing %d URL(s)", len(url_targets))
             url_results = await self.url_strategy.install(url_targets, **install_options)
             results.extend(url_results)
 
         if catalog_targets:
-            logger.info(f"📚 Installing {len(catalog_targets)} catalog app(s)")
+            logger.info("📚 Installing %d catalog app(s)", len(catalog_targets))
             catalog_results = await self.catalog_strategy.install(
                 catalog_targets, **install_options
             )
@@ -195,7 +195,7 @@ def _print_installation_summary(self, results: list[dict[str, Any]]) -> None:
         logger.info("=" * 60)
 
         if successful:
-            logger.info(f"✅ Successfully installed ({len(successful)}):")
+            logger.info("✅ Successfully installed (%d):", len(successful))
             for result in successful:
                 target = result.get("target", "Unknown")
                 path = result.get("path", "Unknown")
@@ -209,14 +209,16 @@ def _print_installation_summary(self, results: list[dict[str, Any]]) -> None:
 
                 version_info = f" v{version}" if version else ""
                 source_info = f" [{source}]" if source != "unknown" else ""
-                logger.info(f"  • {target}{version_info} → {path}{source_info}{status_info}")
+                logger.info(
+                    "  • %s%s → %s%s%s", target, version_info, path, source_info, status_info
+                )
 
         if failed:
-            logger.info(f"\n❌ Failed installations ({len(failed)}):")
+            logger.info("\n❌ Failed installations (%d):", len(failed))
             for result in failed:
                 target = result.get("target", "Unknown")
                 error = result.get("error", "Unknown error")
-                logger.info(f"  • {target}: {error}")
+                logger.info("  • %s: %s", target, error)
 
         logger.info("=" * 60)
 
@@ -235,7 +237,7 @@ def validate_targets(self, targets: list[str]) -> None:
         except ValidationError:
             raise
 
-        logger.debug(f"✅ Validated {len(targets)} target(s)")
+        logger.debug("✅ Validated %d target(s)", len(targets))
 
     async def cleanup_failed_installations(self, results: list[dict[str, Any]]) -> None:
         """Clean up any failed installations.
@@ -250,7 +252,7 @@ async def cleanup_failed_installations(self, results: list[dict[str, Any]]) -> N
             if path := result.get("path"):
                 file_path = Path(path)
                 if file_path.exists():
-                    logger.debug(f"🧹 Cleaning up failed installation: {file_path}")
+                    logger.debug("🧹 Cleaning up failed installation: %s", file_path)
                     self.storage_service.remove_file(file_path)
 
     def get_installation_stats(self, results: list[dict[str, Any]]) -> dict[str, int]:
@@ -349,10 +351,10 @@ async def execute(self, args: Namespace) -> None:
                     )
 
             except ValidationError as e:
-                logger.error(f"❌ Validation error: {e}")
+                logger.error("❌ Validation error: %s", e)
                 logger.info("💡 Use 'list --available' to see available catalog apps.")
             except Exception as e:
-                logger.error(f"❌ Installation failed: {e}")
+                logger.error("❌ Installation failed: %s", e)
 
     def _expand_comma_separated_targets(self, targets: list[str]) -> list[str]:
         """Expand comma-separated targets into individual targets.

my_unicorn/commands/install.py

@@ -26,7 +26,7 @@ async def _remove_single_app(self, app_name: str, keep_config: bool) -> None:
             app_config = self.config_manager.load_app_config(app_name)
             if not app_config:
                 print(f"❌ App '{app_name}' not found")
-                logger.debug(f"App config for '{app_name}' not found. Skipping removal.")
+                logger.debug("App config for '%s' not found. Skipping removal.", app_name)
                 return
 
             # Remove AppImage files
@@ -46,7 +46,7 @@ async def _remove_single_app(self, app_name: str, keep_config: bool) -> None:
                 print(f"✅ Kept config for {app_name}")
 
         except Exception as e:
-            logger.error(f"Failed to remove {app_name}: {e}", exc_info=True)
+            logger.error("Failed to remove %s: %s", app_name, e, exc_info=True)
             print(f"❌ Failed to remove {app_name}: {e}")
 
     def _remove_appimage_files(self, app_config: dict, app_name: str) -> None:
@@ -64,7 +64,7 @@ def _remove_appimage_files(self, app_config: dict, app_name: str) -> None:
             if path.exists():
                 path.unlink()
                 removed_files.append(str(path))
-                logger.debug(f"Unlinked file: {path}")
+                logger.debug("Removed file: %s", path)
 
         if removed_files:
             print(f"✅ Removed AppImage(s): {', '.join(removed_files)}")
@@ -82,8 +82,8 @@ def _remove_desktop_entry(self, app_name: str) -> None:
             if remove_desktop_entry_for_app(app_name, self.config_manager):
                 print(f"✅ Removed desktop entry for {app_name}")
         except Exception as e:
-            logger.debug(f"Exception occurred while processing app '{app_name}': {e}")
-            logger.warning(f"⚠️  Failed to remove desktop entry: {e}")
+            logger.debug("Exception occurred while processing app '%s': %s", app_name, e)
+            logger.warning("⚠️  Failed to remove desktop entry: %s", e)
 
     def _remove_icon(self, app_config: dict) -> None:
         """Remove icon file if icon config is present."""

my_unicorn/commands/remove.py

@@ -40,7 +40,7 @@ async def execute(self, args: Namespace) -> None:
 
             # Log the selected strategy for debugging
             strategy_name = UpdateStrategyFactory.get_strategy_name(context)
-            logger.debug(f"Selected strategy: {strategy_name}")
+            logger.debug("Selected strategy: %s", strategy_name)
 
             # Validate inputs using the strategy's validation logic
             if not strategy.validate_inputs(context):
@@ -53,10 +53,10 @@ async def execute(self, args: Namespace) -> None:
             UpdateResultDisplay.display_summary(result)
 
             # Log final result for debugging
-            logger.debug(f"Update operation completed: {result.message}")
+            logger.debug("Update operation completed: %s", result.message)
 
         except Exception as e:
-            logger.error(f"Update command failed: {e}")
+            logger.error("Update command failed: %s", e)
             UpdateResultDisplay.display_error(f"Update operation failed: {e}")
 
     def _build_context(self, args: Namespace) -> UpdateContext:

my_unicorn/commands/update.py

@@ -250,7 +250,7 @@ def create_desktop_file(
                         f"Desktop file content changed, updating: {desktop_file_path}"
                     )
                 else:
-                    logger.debug(f"Desktop file unchanged, skipping: {desktop_file_path}")
+                    logger.debug("Desktop file unchanged, skipping: %s", desktop_file_path)
                     return desktop_file_path
             except OSError:
                 # If we can't read the existing file, create a new one
@@ -266,9 +266,9 @@ def create_desktop_file(
                 os.chmod(desktop_file_path, 0o755)
 
                 if desktop_file_path.exists():
-                    logger.info(f"🖥️  Updated desktop entry: {desktop_file_path.name}")
+                    logger.info("🖥️  Updated desktop entry: %s", desktop_file_path.name)
                 else:
-                    logger.info(f"🖥️  Created desktop entry: {desktop_file_path.name}")
+                    logger.info("🖥️  Created desktop entry: %s", desktop_file_path.name)
                 return desktop_file_path
 
             except OSError as e:
@@ -303,7 +303,7 @@ def update_desktop_file(
         """
         existing_file = self.find_existing_desktop_file()
         if not existing_file:
-            logger.warning(f"No existing desktop file found for {self.app_name}")
+            logger.warning("No existing desktop file found for %s", self.app_name)
             return None
 
         # Update by recreating the file
@@ -319,11 +319,13 @@ def update_desktop_file(
             with open(existing_file, "w", encoding="utf-8") as f:
                 f.write(content)
 
-            logger.debug(f"Updated desktop file: {existing_file}")
+            logger.debug("Updated desktop file: %s", existing_file)
             return existing_file
 
         except OSError as e:
-            logger.error(f"Failed to update desktop file {existing_file}: {e}", exc_info=True)
+            logger.error(
+                "Failed to update desktop file %s: %s", existing_file, e, exc_info=True
+            )
             return None
 
     def remove_desktop_file(self) -> bool:
@@ -335,15 +337,17 @@ def remove_desktop_file(self) -> bool:
         """
         existing_file = self.find_existing_desktop_file()
         if not existing_file:
-            logger.debug(f"No desktop file found for {self.app_name}")
+            logger.debug("No desktop file found for %s", self.app_name)
             return False
 
         try:
             existing_file.unlink()
-            logger.debug(f"Removed desktop file: {existing_file}")
+            logger.debug("Removed desktop file: %s", existing_file)
             return True
         except OSError as e:
-            logger.error(f"Failed to remove desktop file {existing_file}: {e}", exc_info=True)
+            logger.error(
+                "Failed to remove desktop file %s: %s", existing_file, e, exc_info=True
+            )
             return False
 
     def _is_browser_app(self) -> bool:
@@ -433,9 +437,9 @@ def parse_desktop_fields(content: str) -> dict[str, str]:
 
         for field in important_fields:
             if existing_fields.get(field) != new_fields.get(field):
-                logger.debug(f"Desktop file field changed: {field}")
-                logger.debug(f"  Old: {existing_fields.get(field)}")
-                logger.debug(f"  New: {new_fields.get(field)}")
+                logger.debug("Desktop file field changed: %s", field)
+                logger.debug("  Old: %s", existing_fields.get(field))
+                logger.debug("  New: %s", new_fields.get(field))
                 return True
 
         return False
@@ -522,7 +526,7 @@ def refresh_desktop_database(self) -> bool:
                 logger.debug("Desktop database refreshed")
                 return True
         except Exception as e:
-            logger.debug(f"Could not refresh desktop database: {e}")
+            logger.debug("Could not refresh desktop database: %s", e)
 
         return False