Skip to content

Commit 8485213

Browse files
committed
chore: Keep logging p0 drop support
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
1 parent a0a5e0c commit 8485213

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ private static class State {
8787
String dataStreamsEndpoint;
8888
boolean supportsLongRunning;
8989
boolean supportsClientSideStats;
90+
boolean supportsDropping;
9091
String state;
9192
String configEndpoint;
9293
String debuggerLogEndpoint;
@@ -184,10 +185,10 @@ private void doDiscovery(State newState) {
184185

185186
if (log.isDebugEnabled()) {
186187
log.debug(
187-
"discovered traceEndpoint={}, metricsEndpoint={}, supportsClientSideStats={}, supportsLongRunning={}, dataStreamsEndpoint={}, configEndpoint={}, evpProxyEndpoint={}, telemetryProxyEndpoint={}",
188+
"discovered traceEndpoint={}, metricsEndpoint={}, supportsDropping={}, supportsLongRunning={}, dataStreamsEndpoint={}, configEndpoint={}, evpProxyEndpoint={}, telemetryProxyEndpoint={}",
188189
newState.traceEndpoint,
189190
newState.metricsEndpoint,
190-
newState.supportsClientSideStats,
191+
newState.supportsDropping,
191192
newState.supportsLongRunning,
192193
newState.dataStreamsEndpoint,
193194
newState.configEndpoint,
@@ -306,13 +307,15 @@ private boolean processInfoResponse(State newState, String response) {
306307
Boolean.TRUE.equals(map.getOrDefault("long_running_spans", false));
307308

308309
if (metricsEnabled) {
309-
newState.supportsClientSideStats = !AgentVersion.isVersionBelow(newState.version, 7, 65, 0);
310310
Object canDrop = map.get("client_drop_p0s");
311-
newState.supportsClientSideStats &=
311+
newState.supportsDropping =
312312
null != canDrop
313313
&& ("true".equalsIgnoreCase(String.valueOf(canDrop))
314314
|| Boolean.TRUE.equals(canDrop));
315315

316+
newState.supportsClientSideStats =
317+
newState.supportsDropping && !AgentVersion.isVersionBelow(newState.version, 7, 65, 0);
318+
316319
Object peer_tags = map.get("peer_tags");
317320
newState.peerTags =
318321
peer_tags instanceof List

0 commit comments

Comments
 (0)