removing add.span.pointers as a config and using it as a suffix instead

Author: mhlidd

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

@@ -293,7 +293,6 @@ public final class ConfigDefaults {
   static final boolean DEFAULT_ELASTICSEARCH_BODY_ENABLED = false;
   static final boolean DEFAULT_ELASTICSEARCH_PARAMS_ENABLED = true;
   static final boolean DEFAULT_ELASTICSEARCH_BODY_AND_PARAMS_ENABLED = false;
-  static final boolean DEFAULT_ADD_SPAN_POINTERS = true;
 
   static final boolean DEFAULT_SPARK_TASK_HISTOGRAM_ENABLED = true;
   static final boolean DEFAULT_SPARK_APP_NAME_AS_SERVICE = false;

dd-trace-api/src/main/java/datadog/trace/api/config/TraceInstrumentationConfig.java

@@ -195,7 +195,6 @@ public final class TraceInstrumentationConfig {
   public static final String AXIS_PROMOTE_RESOURCE_NAME = "trace.axis.promote.resource-name";
 
   public static final String SQS_BODY_PROPAGATION_ENABLED = "trace.sqs.body.propagation.enabled";
-  public static final String ADD_SPAN_POINTERS = "add.span.pointers";
 
   private TraceInstrumentationConfig() {}
 }

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -2,7 +2,6 @@
 
 import static datadog.environment.JavaVirtualMachine.isJavaVersion;
 import static datadog.environment.JavaVirtualMachine.isJavaVersionAtLeast;
-import static datadog.trace.api.ConfigDefaults.DEFAULT_ADD_SPAN_POINTERS;
 import static datadog.trace.api.ConfigDefaults.DEFAULT_AGENT_HOST;
 import static datadog.trace.api.ConfigDefaults.DEFAULT_AGENT_TIMEOUT;
 import static datadog.trace.api.ConfigDefaults.DEFAULT_AGENT_WRITER_TYPE;
@@ -519,7 +518,6 @@
 import static datadog.trace.api.config.RumConfig.RUM_TRACK_RESOURCES;
 import static datadog.trace.api.config.RumConfig.RUM_TRACK_USER_INTERACTION;
 import static datadog.trace.api.config.RumConfig.RUM_VERSION;
-import static datadog.trace.api.config.TraceInstrumentationConfig.ADD_SPAN_POINTERS;
 import static datadog.trace.api.config.TraceInstrumentationConfig.AXIS_PROMOTE_RESOURCE_NAME;
 import static datadog.trace.api.config.TraceInstrumentationConfig.CASSANDRA_KEYSPACE_STATEMENT_EXTRACTION_ENABLED;
 import static datadog.trace.api.config.TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED;
@@ -5262,11 +5260,7 @@ public boolean isTimeInQueueEnabled(
   }
 
   public boolean isAddSpanPointers(final String integrationName) {
-    return configProvider.isEnabled(
-        Collections.singletonList(ADD_SPAN_POINTERS),
-        integrationName,
-        "",
-        DEFAULT_ADD_SPAN_POINTERS);
+    return configProvider.isEnabled(Arrays.asList(integrationName), "", "add.span.pointers", true);
   }
 
   public boolean isEnabled(

metadata/supported-configurations.json

@@ -2,7 +2,6 @@
   "supportedConfigurations": {
     "DD_AAS_JAVA_EXTENSION_VERSION": ["A"],
     "DD_ACTION_EXECUTION_ID": ["A"],
-    "DD_ADD_SPAN_POINTERS": ["A"],
     "DD_AGENTLESS_LOG_SUBMISSION_ENABLED": ["A"],
     "DD_AGENTLESS_LOG_SUBMISSION_LEVEL": ["A"],
     "DD_AGENTLESS_LOG_SUBMISSION_QUEUE_SIZE": ["A"],