-
Notifications
You must be signed in to change notification settings - Fork 319
Add Gradle Task to Parse V2 supported-configurations.json Format
#10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085235
Total [baseline] (10.877 s) : 0, 10877136
Agent [candidate] (1.088 s) : 0, 1087632
Total [candidate] (10.831 s) : 0, 10830978
section appsec
Agent [baseline] (1.264 s) : 0, 1264496
Total [baseline] (11.094 s) : 0, 11093751
Agent [candidate] (1.264 s) : 0, 1263968
Total [candidate] (11.097 s) : 0, 11096760
section iast
Agent [baseline] (1.229 s) : 0, 1229423
Total [baseline] (11.22 s) : 0, 11219731
Agent [candidate] (1.232 s) : 0, 1232120
Total [candidate] (11.126 s) : 0, 11125844
section profiling
Agent [baseline] (1.22 s) : 0, 1219885
Total [baseline] (11.075 s) : 0, 11075207
Agent [candidate] (1.21 s) : 0, 1209680
Total [candidate] (11.095 s) : 0, 11094728
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (649.883 ms) : 0, 649883
BytebuddyAgent [candidate] (652.962 ms) : 0, 652962
GlobalTracer [baseline] (283.698 ms) : 0, 283698
GlobalTracer [candidate] (283.27 ms) : 0, 283270
AppSec [baseline] (32.749 ms) : 0, 32749
AppSec [candidate] (32.54 ms) : 0, 32540
Debugger [baseline] (68.501 ms) : 0, 68501
Debugger [candidate] (68.506 ms) : 0, 68506
Remote Config [baseline] (652.227 µs) : 0, 652
Remote Config [candidate] (643.178 µs) : 0, 643
Telemetry [baseline] (9.12 ms) : 0, 9120
Telemetry [candidate] (9.107 ms) : 0, 9107
Flare Poller [baseline] (3.829 ms) : 0, 3829
Flare Poller [candidate] (3.84 ms) : 0, 3840
section appsec
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (688.789 ms) : 0, 688789
BytebuddyAgent [candidate] (689.425 ms) : 0, 689425
GlobalTracer [baseline] (259.335 ms) : 0, 259335
GlobalTracer [candidate] (259.229 ms) : 0, 259229
AppSec [baseline] (174.528 ms) : 0, 174528
AppSec [candidate] (173.805 ms) : 0, 173805
Debugger [baseline] (66.683 ms) : 0, 66683
Debugger [candidate] (66.503 ms) : 0, 66503
Remote Config [baseline] (736.943 µs) : 0, 737
Remote Config [candidate] (707.705 µs) : 0, 708
Telemetry [baseline] (9.128 ms) : 0, 9128
Telemetry [candidate] (9.124 ms) : 0, 9124
Flare Poller [baseline] (3.928 ms) : 0, 3928
Flare Poller [candidate] (3.941 ms) : 0, 3941
IAST [baseline] (24.654 ms) : 0, 24654
IAST [candidate] (24.563 ms) : 0, 24563
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (794.563 ms) : 0, 794563
BytebuddyAgent [candidate] (797.709 ms) : 0, 797709
GlobalTracer [baseline] (256.905 ms) : 0, 256905
GlobalTracer [candidate] (256.924 ms) : 0, 256924
AppSec [baseline] (34.472 ms) : 0, 34472
AppSec [candidate] (35.683 ms) : 0, 35683
Debugger [baseline] (67.055 ms) : 0, 67055
Debugger [candidate] (65.552 ms) : 0, 65552
Remote Config [baseline] (604.741 µs) : 0, 605
Remote Config [candidate] (550.723 µs) : 0, 551
Telemetry [baseline] (8.461 ms) : 0, 8461
Telemetry [candidate] (8.399 ms) : 0, 8399
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.416 ms) : 0, 3416
IAST [baseline] (27.205 ms) : 0, 27205
IAST [candidate] (27.219 ms) : 0, 27219
section profiling
ProfilingAgent [baseline] (97.874 ms) : 0, 97874
ProfilingAgent [candidate] (97.781 ms) : 0, 97781
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (710.946 ms) : 0, 710946
BytebuddyAgent [candidate] (705.242 ms) : 0, 705242
GlobalTracer [baseline] (224.105 ms) : 0, 224105
GlobalTracer [candidate] (221.656 ms) : 0, 221656
AppSec [baseline] (33.11 ms) : 0, 33110
AppSec [candidate] (32.52 ms) : 0, 32520
Debugger [baseline] (68.783 ms) : 0, 68783
Debugger [candidate] (67.966 ms) : 0, 67966
Remote Config [baseline] (657.673 µs) : 0, 658
Remote Config [candidate] (628.601 µs) : 0, 629
Telemetry [baseline] (9.112 ms) : 0, 9112
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.835 ms) : 0, 3835
Flare Poller [candidate] (3.79 ms) : 0, 3790
Profiling [baseline] (98.483 ms) : 0, 98483
Profiling [candidate] (98.371 ms) : 0, 98371
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086246
Total [baseline] (8.78 s) : 0, 8779930
Agent [candidate] (1.079 s) : 0, 1078768
Total [candidate] (8.742 s) : 0, 8741799
section iast
Agent [baseline] (1.235 s) : 0, 1235462
Total [baseline] (9.495 s) : 0, 9495102
Agent [candidate] (1.238 s) : 0, 1238441
Total [candidate] (9.442 s) : 0, 9442165
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (652.247 ms) : 0, 652247
BytebuddyAgent [candidate] (647.837 ms) : 0, 647837
GlobalTracer [baseline] (283.4 ms) : 0, 283400
GlobalTracer [candidate] (281.242 ms) : 0, 281242
AppSec [baseline] (32.541 ms) : 0, 32541
AppSec [candidate] (32.375 ms) : 0, 32375
Debugger [baseline] (67.596 ms) : 0, 67596
Debugger [candidate] (67.261 ms) : 0, 67261
Remote Config [baseline] (676.593 µs) : 0, 677
Remote Config [candidate] (648.143 µs) : 0, 648
Telemetry [baseline] (9.084 ms) : 0, 9084
Telemetry [candidate] (8.982 ms) : 0, 8982
Flare Poller [baseline] (3.844 ms) : 0, 3844
Flare Poller [candidate] (3.722 ms) : 0, 3722
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (800.376 ms) : 0, 800376
BytebuddyAgent [candidate] (802.528 ms) : 0, 802528
GlobalTracer [baseline] (257.892 ms) : 0, 257892
GlobalTracer [candidate] (258.747 ms) : 0, 258747
AppSec [baseline] (35.63 ms) : 0, 35630
AppSec [candidate] (35.411 ms) : 0, 35411
Debugger [baseline] (64.931 ms) : 0, 64931
Debugger [candidate] (65.173 ms) : 0, 65173
Remote Config [baseline] (584.584 µs) : 0, 585
Remote Config [candidate] (585.741 µs) : 0, 586
Telemetry [baseline] (8.488 ms) : 0, 8488
Telemetry [candidate] (8.442 ms) : 0, 8442
Flare Poller [baseline] (3.45 ms) : 0, 3450
Flare Poller [candidate] (3.435 ms) : 0, 3435
IAST [baseline] (27.369 ms) : 0, 27369
IAST [candidate] (27.296 ms) : 0, 27296
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (18.148 ms) : 17967, 18328
. : milestone, 18148,
appsec (18.535 ms) : 18347, 18723
. : milestone, 18535,
code_origins (17.76 ms) : 17581, 17939
. : milestone, 17760,
iast (17.399 ms) : 17226, 17573
. : milestone, 17399,
profiling (18.682 ms) : 18492, 18871
. : milestone, 18682,
tracing (17.598 ms) : 17423, 17772
. : milestone, 17598,
section candidate
no_agent (18.273 ms) : 18086, 18461
. : milestone, 18273,
appsec (18.557 ms) : 18372, 18742
. : milestone, 18557,
code_origins (17.569 ms) : 17392, 17746
. : milestone, 17569,
iast (17.673 ms) : 17497, 17849
. : milestone, 17673,
profiling (18.692 ms) : 18504, 18881
. : milestone, 18692,
tracing (17.459 ms) : 17289, 17629
. : milestone, 17459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.219 ms) : 1207, 1230
. : milestone, 1219,
iast (3.212 ms) : 3175, 3249
. : milestone, 3212,
iast_FULL (5.97 ms) : 5910, 6031
. : milestone, 5970,
iast_GLOBAL (3.444 ms) : 3396, 3492
. : milestone, 3444,
profiling (2.008 ms) : 1989, 2026
. : milestone, 2008,
tracing (1.883 ms) : 1867, 1899
. : milestone, 1883,
section candidate
no_agent (1.201 ms) : 1190, 1212
. : milestone, 1201,
iast (3.257 ms) : 3212, 3303
. : milestone, 3257,
iast_FULL (5.939 ms) : 5879, 5999
. : milestone, 5939,
iast_GLOBAL (3.504 ms) : 3449, 3558
. : milestone, 3504,
profiling (2.129 ms) : 2110, 2149
. : milestone, 2129,
tracing (1.858 ms) : 1842, 1873
. : milestone, 1858,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.411 s) : 15411000, 15411000
. : milestone, 15411000,
appsec (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (14.59 s) : 14590000, 14590000
. : milestone, 14590000,
section candidate
no_agent (15.266 s) : 15266000, 15266000
. : milestone, 15266000,
appsec (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
iast (18.185 s) : 18185000, 18185000
. : milestone, 18185000,
iast_GLOBAL (17.802 s) : 17802000, 17802000
. : milestone, 17802000,
profiling (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8b895b2536, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.709 ms) : 3489, 3928
. : milestone, 3709,
iast (2.219 ms) : 2154, 2284
. : milestone, 2219,
iast_GLOBAL (2.273 ms) : 2207, 2339
. : milestone, 2273,
profiling (2.073 ms) : 2020, 2126
. : milestone, 2073,
tracing (2.052 ms) : 2001, 2104
. : milestone, 2052,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.661 ms) : 3445, 3878
. : milestone, 3661,
iast (2.218 ms) : 2154, 2283
. : milestone, 2218,
iast_GLOBAL (2.256 ms) : 2191, 2322
. : milestone, 2256,
profiling (2.086 ms) : 2031, 2140
. : milestone, 2086,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment as part of mentoring. I will leave the full review / feedback to the reviewers :)
utils/config-utils/src/main/java/datadog/trace/config/inversion/SupportedConfiguration.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Show resolved
Hide resolved
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Outdated
Show resolved
Hide resolved
| if (s == null) "null" else "\"${esc(s)}\"" | ||
| } | ||
|
|
||
| data class SupportedConfiguration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I'd rename this one as it is confusing with the outer class with the same name.
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Show resolved
Hide resolved
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving.
What Does This Do
This PR adds a new Gradle task to parse the V2 format for the local
supported-configurations.jsonfile. This task is based off of the original parsing taskParseSupportedConfigurationsTaskwhich handled the V1 format.Note that this is the first of many PRs to migrate to the V2 format. This task will be hooked into the generate task in a future PR.
Below are examples of the format of the two files:
This PR creates a new Java class
SupportedConfiguration.javainutils:config-utilsto support storing an individual Config version. The Gradle task parses the JSON and stores the data in instances of the object. Consequently, the new generated classGeneratedSupportedConfiguration.javawill now store aMap<String, List<SupportedConfiguration>>in itsSUPPORTEDfield.Additionally, the new V2 format does not have a top-level aliases field; rather aliases are tied to config versions. Until Config Registry becomes mature enough to understand what version of a config the customer is using, we will still generate a top-level aliases map that considers all aliases of a config, regardless of which version is actually being used.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]