Skip to content

Conversation

@mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Dec 5, 2025

What Does This Do

As part of the process of migrating to a V2 supported-configurations.json format, I added logging to each call in ConfigProvider that queried the ConfigHelper to generate documentation on the configs in the tracer. This led to discoveries of some inaccuracies, particularly with aliases, that are addressed in this PR.

Additionally, this PR cleans up configs that are not referenced at all in the library, restructures the add.span.pointers suffix to remove it as a config definition, and renames DD_UNDERTOW_CONTINUATION to prevent devs from confusing it as a config (used as a key in instrumentation, not actually a config).

With this updated local file, we can properly generate documentation for these configurations in #10078 (WIP) and officially "migrate" to the v2 format.

Note that many of the *_PROPAGATION_* configs were falsely listed as unique env vars when they are actually aliases. Thus, they were removed from the supportedConfigurations key and added to the aliases key instead.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd mhlidd force-pushed the mhlidd/update_supported-configurations branch from 424147d to 1751acd Compare December 5, 2025 22:51
@mhlidd mhlidd marked this pull request as ready for review December 5, 2025 23:25
@mhlidd mhlidd requested review from a team as code owners December 5, 2025 23:25
@mhlidd mhlidd requested review from amarziali and removed request for a team December 5, 2025 23:25
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: config Configuration labels Dec 5, 2025
@mhlidd mhlidd changed the title Cleaning Up supported-configurations.json Cleaning Up Unused and Ambiguous Configurations Dec 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/update_supported-configurations
git_commit_date 1764970693 1765237332
git_commit_sha 823cec6 a2573b5
release_version 1.57.0-SNAPSHOT~823cec6aa6 1.57.0-SNAPSHOT~a2573b581c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765239361 1765239361
ci_job_id 1277883328 1277883328
ci_pipeline_id 85445504 85445504
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-pm5t2l7v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-pm5t2l7v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079784
Total [baseline] (10.782 s) : 0, 10781837
Agent [candidate] (1.081 s) : 0, 1080651
Total [candidate] (10.777 s) : 0, 10777219
section appsec
Agent [baseline] (1.266 s) : 0, 1266103
Total [baseline] (11.195 s) : 0, 11194900
Agent [candidate] (1.265 s) : 0, 1265105
Total [candidate] (11.186 s) : 0, 11185553
section iast
Agent [baseline] (1.229 s) : 0, 1228836
Total [baseline] (11.224 s) : 0, 11223550
Agent [candidate] (1.22 s) : 0, 1219599
Total [candidate] (11.139 s) : 0, 11139267
section profiling
Agent [baseline] (1.204 s) : 0, 1203620
Total [baseline] (11.016 s) : 0, 11015647
Agent [candidate] (1.202 s) : 0, 1201685
Total [candidate] (11.026 s) : 0, 11026339
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.266 s 186.319 ms (17.3%)
Agent iast 1.229 s 149.052 ms (13.8%)
Agent profiling 1.204 s 123.836 ms (11.5%)
Total tracing 10.782 s -
Total appsec 11.195 s 413.063 ms (3.8%)
Total iast 11.224 s 441.713 ms (4.1%)
Total profiling 11.016 s 233.81 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.265 s 184.454 ms (17.1%)
Agent iast 1.22 s 138.948 ms (12.9%)
Agent profiling 1.202 s 121.034 ms (11.2%)
Total tracing 10.777 s -
Total appsec 11.186 s 408.334 ms (3.8%)
Total iast 11.139 s 362.048 ms (3.4%)
Total profiling 11.026 s 249.12 ms (2.3%)
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (647.386 ms) : 0, 647386
BytebuddyAgent [candidate] (648.399 ms) : 0, 648399
GlobalTracer [baseline] (281.526 ms) : 0, 281526
GlobalTracer [candidate] (282.083 ms) : 0, 282083
AppSec [baseline] (32.37 ms) : 0, 32370
AppSec [candidate] (32.376 ms) : 0, 32376
Debugger [baseline] (68.476 ms) : 0, 68476
Debugger [candidate] (67.766 ms) : 0, 67766
Remote Config [baseline] (679.959 µs) : 0, 680
Remote Config [candidate] (642.991 µs) : 0, 643
Telemetry [baseline] (9.003 ms) : 0, 9003
Telemetry [candidate] (8.993 ms) : 0, 8993
Flare Poller [baseline] (3.679 ms) : 0, 3679
Flare Poller [candidate] (3.759 ms) : 0, 3759
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (689.789 ms) : 0, 689789
BytebuddyAgent [candidate] (688.627 ms) : 0, 688627
GlobalTracer [baseline] (259.184 ms) : 0, 259184
GlobalTracer [candidate] (259.427 ms) : 0, 259427
AppSec [baseline] (174.772 ms) : 0, 174772
AppSec [candidate] (174.363 ms) : 0, 174363
Debugger [baseline] (67.31 ms) : 0, 67310
Debugger [candidate] (67.903 ms) : 0, 67903
Remote Config [baseline] (686.887 µs) : 0, 687
Remote Config [candidate] (730.261 µs) : 0, 730
Telemetry [baseline] (8.938 ms) : 0, 8938
Telemetry [candidate] (8.982 ms) : 0, 8982
Flare Poller [baseline] (3.922 ms) : 0, 3922
Flare Poller [candidate] (3.898 ms) : 0, 3898
IAST [baseline] (24.733 ms) : 0, 24733
IAST [candidate] (24.537 ms) : 0, 24537
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (794.786 ms) : 0, 794786
BytebuddyAgent [candidate] (787.776 ms) : 0, 787776
GlobalTracer [baseline] (255.435 ms) : 0, 255435
GlobalTracer [candidate] (254.965 ms) : 0, 254965
AppSec [baseline] (35.56 ms) : 0, 35560
AppSec [candidate] (35.373 ms) : 0, 35373
Debugger [baseline] (66.599 ms) : 0, 66599
Debugger [candidate] (65.648 ms) : 0, 65648
Remote Config [baseline] (562.406 µs) : 0, 562
Remote Config [candidate] (554.283 µs) : 0, 554
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.424 ms) : 0, 8424
Flare Poller [baseline] (3.483 ms) : 0, 3483
Flare Poller [candidate] (3.469 ms) : 0, 3469
IAST [baseline] (27.172 ms) : 0, 27172
IAST [candidate] (26.889 ms) : 0, 26889
section profiling
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (700.772 ms) : 0, 700772
BytebuddyAgent [candidate] (699.833 ms) : 0, 699833
GlobalTracer [baseline] (220.291 ms) : 0, 220291
GlobalTracer [candidate] (220.258 ms) : 0, 220258
AppSec [baseline] (32.387 ms) : 0, 32387
AppSec [candidate] (32.238 ms) : 0, 32238
Debugger [baseline] (68.079 ms) : 0, 68079
Debugger [candidate] (67.641 ms) : 0, 67641
Remote Config [baseline] (648.826 µs) : 0, 649
Remote Config [candidate] (610.008 µs) : 0, 610
Telemetry [baseline] (9.039 ms) : 0, 9039
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.793 ms) : 0, 3793
ProfilingAgent [baseline] (97.963 ms) : 0, 97963
ProfilingAgent [candidate] (97.764 ms) : 0, 97764
Profiling [baseline] (98.546 ms) : 0, 98546
Profiling [candidate] (98.334 ms) : 0, 98334
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089422
Total [baseline] (8.76 s) : 0, 8759657
Agent [candidate] (1.088 s) : 0, 1087685
Total [candidate] (8.757 s) : 0, 8757479
section iast
Agent [baseline] (1.225 s) : 0, 1224759
Total [baseline] (9.509 s) : 0, 9508509
Agent [candidate] (1.238 s) : 0, 1237699
Total [candidate] (9.453 s) : 0, 9452767
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.225 s 135.337 ms (12.4%)
Total tracing 8.76 s -
Total iast 9.509 s 748.851 ms (8.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent iast 1.238 s 150.015 ms (13.8%)
Total tracing 8.757 s -
Total iast 9.453 s 695.288 ms (7.9%)
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (655.596 ms) : 0, 655596
BytebuddyAgent [candidate] (653.015 ms) : 0, 653015
GlobalTracer [baseline] (282.805 ms) : 0, 282805
GlobalTracer [candidate] (284.172 ms) : 0, 284172
AppSec [baseline] (32.446 ms) : 0, 32446
AppSec [candidate] (32.773 ms) : 0, 32773
Debugger [baseline] (68.099 ms) : 0, 68099
Debugger [candidate] (67.47 ms) : 0, 67470
Remote Config [baseline] (663.782 µs) : 0, 664
Remote Config [candidate] (667.958 µs) : 0, 668
Telemetry [baseline] (9.072 ms) : 0, 9072
Telemetry [candidate] (9.063 ms) : 0, 9063
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.712 ms) : 0, 3712
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (791.689 ms) : 0, 791689
BytebuddyAgent [candidate] (801.478 ms) : 0, 801478
GlobalTracer [baseline] (255.738 ms) : 0, 255738
GlobalTracer [candidate] (258.651 ms) : 0, 258651
AppSec [baseline] (35.471 ms) : 0, 35471
AppSec [candidate] (34.804 ms) : 0, 34804
Debugger [baseline] (65.458 ms) : 0, 65458
Debugger [candidate] (65.983 ms) : 0, 65983
Remote Config [baseline] (566.831 µs) : 0, 567
Remote Config [candidate] (559.477 µs) : 0, 559
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (8.452 ms) : 0, 8452
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.521 ms) : 0, 3521
IAST [baseline] (27.044 ms) : 0, 27044
IAST [candidate] (27.403 ms) : 0, 27403
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/update_supported-configurations
git_commit_date 1764970693 1765237332
git_commit_sha 823cec6 a2573b5
release_version 1.57.0-SNAPSHOT~823cec6aa6 1.57.0-SNAPSHOT~a2573b581c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765239647 1765239647
ci_job_id 1277883329 1277883329
ci_pipeline_id 85445504 85445504
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jwytw455 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jwytw455 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1208
.   : milestone, 1197,
iast (3.345 ms) : 3302, 3388
.   : milestone, 3345,
iast_FULL (5.639 ms) : 5584, 5694
.   : milestone, 5639,
iast_GLOBAL (3.475 ms) : 3423, 3527
.   : milestone, 3475,
profiling (2.01 ms) : 1993, 2028
.   : milestone, 2010,
tracing (1.779 ms) : 1764, 1794
.   : milestone, 1779,
section candidate
no_agent (1.234 ms) : 1222, 1247
.   : milestone, 1234,
iast (3.257 ms) : 3213, 3302
.   : milestone, 3257,
iast_FULL (5.746 ms) : 5689, 5803
.   : milestone, 5746,
iast_GLOBAL (3.602 ms) : 3543, 3661
.   : milestone, 3602,
profiling (2.103 ms) : 2084, 2122
.   : milestone, 2103,
tracing (1.846 ms) : 1828, 1864
.   : milestone, 1846,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.197 ms [1.185 ms, 1.208 ms] -
iast 3.345 ms [3.302 ms, 3.388 ms] 2.148 ms (179.5%)
iast_FULL 5.639 ms [5.584 ms, 5.694 ms] 4.443 ms (371.3%)
iast_GLOBAL 3.475 ms [3.423 ms, 3.527 ms] 2.278 ms (190.4%)
profiling 2.01 ms [1.993 ms, 2.028 ms] 813.903 µs (68.0%)
tracing 1.779 ms [1.764 ms, 1.794 ms] 582.616 µs (48.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.234 ms [1.222 ms, 1.247 ms] -
iast 3.257 ms [3.213 ms, 3.302 ms] 2.023 ms (163.9%)
iast_FULL 5.746 ms [5.689 ms, 5.803 ms] 4.511 ms (365.5%)
iast_GLOBAL 3.602 ms [3.543 ms, 3.661 ms] 2.367 ms (191.8%)
profiling 2.103 ms [2.084 ms, 2.122 ms] 868.564 µs (70.4%)
tracing 1.846 ms [1.828 ms, 1.864 ms] 611.993 µs (49.6%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.248 ms) : 18061, 18434
.   : milestone, 18248,
appsec (18.818 ms) : 18630, 19007
.   : milestone, 18818,
code_origins (17.941 ms) : 17759, 18123
.   : milestone, 17941,
iast (17.655 ms) : 17484, 17826
.   : milestone, 17655,
profiling (19.72 ms) : 19520, 19920
.   : milestone, 19720,
tracing (17.716 ms) : 17539, 17892
.   : milestone, 17716,
section candidate
no_agent (18.481 ms) : 18290, 18672
.   : milestone, 18481,
appsec (18.933 ms) : 18742, 19125
.   : milestone, 18933,
code_origins (18.089 ms) : 17911, 18268
.   : milestone, 18089,
iast (17.894 ms) : 17713, 18075
.   : milestone, 17894,
profiling (19.17 ms) : 18980, 19361
.   : milestone, 19170,
tracing (17.51 ms) : 17339, 17681
.   : milestone, 17510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.248 ms [18.061 ms, 18.434 ms] -
appsec 18.818 ms [18.63 ms, 19.007 ms] 570.267 µs (3.1%)
code_origins 17.941 ms [17.759 ms, 18.123 ms] -306.739 µs (-1.7%)
iast 17.655 ms [17.484 ms, 17.826 ms] -592.798 µs (-3.2%)
profiling 19.72 ms [19.52 ms, 19.92 ms] 1.472 ms (8.1%)
tracing 17.716 ms [17.539 ms, 17.892 ms] -532.13 µs (-2.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.481 ms [18.29 ms, 18.672 ms] -
appsec 18.933 ms [18.742 ms, 19.125 ms] 452.353 µs (2.4%)
code_origins 18.089 ms [17.911 ms, 18.268 ms] -391.707 µs (-2.1%)
iast 17.894 ms [17.713 ms, 18.075 ms] -586.901 µs (-3.2%)
profiling 19.17 ms [18.98 ms, 19.361 ms] 689.406 µs (3.7%)
tracing 17.51 ms [17.339 ms, 17.681 ms] -970.935 µs (-5.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/update_supported-configurations
git_commit_date 1764970693 1765237332
git_commit_sha 823cec6 a2573b5
release_version 1.57.0-SNAPSHOT~823cec6aa6 1.57.0-SNAPSHOT~a2573b581c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1765239302 1765239302
ci_job_id 1277883330 1277883330
ci_pipeline_id 85445504 85445504
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-jyrjts3j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-jyrjts3j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (3.635 ms) : 3419, 3851
.   : milestone, 3635,
iast (2.211 ms) : 2147, 2275
.   : milestone, 2211,
iast_GLOBAL (2.25 ms) : 2185, 2314
.   : milestone, 2250,
profiling (2.051 ms) : 1999, 2103
.   : milestone, 2051,
tracing (2.033 ms) : 1983, 2084
.   : milestone, 2033,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (3.642 ms) : 3429, 3854
.   : milestone, 3642,
iast (2.204 ms) : 2140, 2268
.   : milestone, 2204,
iast_GLOBAL (2.249 ms) : 2184, 2315
.   : milestone, 2249,
profiling (2.469 ms) : 2309, 2630
.   : milestone, 2469,
tracing (2.036 ms) : 1985, 2086
.   : milestone, 2036,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 3.635 ms [3.419 ms, 3.851 ms] 2.166 ms (147.5%)
iast 2.211 ms [2.147 ms, 2.275 ms] 742.032 µs (50.5%)
iast_GLOBAL 2.25 ms [2.185 ms, 2.314 ms] 780.727 µs (53.2%)
profiling 2.051 ms [1.999 ms, 2.103 ms] 582.172 µs (39.6%)
tracing 2.033 ms [1.983 ms, 2.084 ms] 564.451 µs (38.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 3.642 ms [3.429 ms, 3.854 ms] 2.173 ms (148.0%)
iast 2.204 ms [2.14 ms, 2.268 ms] 735.212 µs (50.1%)
iast_GLOBAL 2.249 ms [2.184 ms, 2.315 ms] 780.678 µs (53.2%)
profiling 2.469 ms [2.309 ms, 2.63 ms] 1.001 ms (68.1%)
tracing 2.036 ms [1.985 ms, 2.086 ms] 566.921 µs (38.6%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a2573b581c, baseline=1.57.0-SNAPSHOT~823cec6aa6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.281 s) : 15281000, 15281000
.   : milestone, 15281000,
appsec (14.819 s) : 14819000, 14819000
.   : milestone, 14819000,
iast (18.953 s) : 18953000, 18953000
.   : milestone, 18953000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
.   : milestone, 17908000,
profiling (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
tracing (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
section candidate
no_agent (15.255 s) : 15255000, 15255000
.   : milestone, 15255000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.168 s) : 18168000, 18168000
.   : milestone, 18168000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
.   : milestone, 17962000,
profiling (15.201 s) : 15201000, 15201000
.   : milestone, 15201000,
tracing (14.701 s) : 14701000, 14701000
.   : milestone, 14701000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.281 s [15.281 s, 15.281 s] -
appsec 14.819 s [14.819 s, 14.819 s] -462.0 ms (-3.0%)
iast 18.953 s [18.953 s, 18.953 s] 3.672 s (24.0%)
iast_GLOBAL 17.908 s [17.908 s, 17.908 s] 2.627 s (17.2%)
profiling 15.202 s [15.202 s, 15.202 s] -79.0 ms (-0.5%)
tracing 14.925 s [14.925 s, 14.925 s] -356.0 ms (-2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.255 s [15.255 s, 15.255 s] -
appsec 15.016 s [15.016 s, 15.016 s] -239.0 ms (-1.6%)
iast 18.168 s [18.168 s, 18.168 s] 2.913 s (19.1%)
iast_GLOBAL 17.962 s [17.962 s, 17.962 s] 2.707 s (17.7%)
profiling 15.201 s [15.201 s, 15.201 s] -54.0 ms (-0.4%)
tracing 14.701 s [14.701 s, 14.701 s] -554.0 ms (-3.6%)

integrationName,
"",
DEFAULT_ADD_SPAN_POINTERS);
return configProvider.isEnabled(Arrays.asList(integrationName), "", "add.span.pointers", true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it make sense to extend configProvider.isEnabled() to accept single name?
I can see a lot of places in code wrapping string into list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can definitely be refactored to have a function that takes in the array to call another function take in a single name, but IMO that's out of scope for this PR and should be introduced in a follow-up. I can handle that when I have a chance in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: config Configuration tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants