Skip to content

Commit 25fa1e4

Browse files
authored
ci: enable SLO change detection, make benchmark checks interruptible (#7005)
* make notify-slo-breaches when: always explicit * add slo change detection * check-big-regression should mimic benchmarks rules * (check|notify)-slo-breaches should mimic macrobenchmarks rules * trigger ci: are micros and macros interrupted? * test SLO change detection * Revert "test SLO change detection" This reverts commit a2bfd86. * fix dd-octo-sts self.gitlab.read trust policy name
1 parent 105cb8c commit 25fa1e4

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed
File renamed without changes.

.gitlab/benchmarks.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ variables:
1414
rules:
1515
- if: '$CI_COMMIT_REF_NAME =~ /^graphite-base\/.*$/'
1616
when: never
17-
- when: on_success
1817
- if: $CI_COMMIT_BRANCH == 'master'
1918
interruptible: false
2019
- interruptible: true
@@ -57,7 +56,9 @@ check-big-regressions:
5756
rules:
5857
- if: '$CI_COMMIT_REF_NAME =~ /^graphite-base\/.*$/'
5958
when: never
60-
- when: on_success
59+
- if: $CI_COMMIT_BRANCH == 'master'
60+
interruptible: false
61+
- interruptible: true
6162
tags: ["arch:amd64"]
6263
image: $MICROBENCHMARKS_CI_IMAGE
6364
script:

.gitlab/macrobenchmarks.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ include:
66

77
.macrobenchmarks:
88
stage: macrobenchmarks
9-
when: always
109
rules:
1110
- if: '$CI_COMMIT_REF_NAME =~ /^graphite-base\/.*$/'
1211
when: never
1312
- if: $CI_COMMIT_BRANCH == 'master'
13+
when: always
1414
interruptible: false
1515
- interruptible: true
1616
tags: ["runner:apm-k8s-same-cpu"]
@@ -103,17 +103,31 @@ check-slo-breaches:
103103
- baseline
104104
- only-tracing
105105
- only-tracing-with-runtime-metrics-enabled
106+
rules:
107+
- if: $CI_COMMIT_BRANCH == 'master'
108+
when: always
109+
interruptible: false
110+
- interruptible: true
106111
artifacts:
107112
name: "artifacts"
108113
when: always
109114
paths:
110115
- platform/artifacts/
111116
expire_in: 3 months
117+
variables:
118+
DDOCTOSTS_POLICY: "self.gitlab.read"
119+
ARTIFACTS_DIR: "platform/artifacts"
120+
SLO_FILE: ".gitlab/benchmarks/bp-runner.fail-on-breach.yml"
112121

113122
notify-slo-breaches:
114123
extends: .notify-slo-breaches
115124
stage: macrobenchmarks-notify
116125
needs:
117126
- check-slo-breaches
127+
rules:
128+
- if: $CI_COMMIT_BRANCH == 'master'
129+
when: always
130+
interruptible: false
131+
- interruptible: true
118132
variables:
119133
CHANNEL: "notifications-apm-js"

0 commit comments

Comments
 (0)