Skip to content

Commit 64d9750

Browse files
refactor(profiling): clarify init order in TaskInfo
1 parent a7baa36 commit 64d9750

File tree

1 file changed

+4
-5
lines changed
  • ddtrace/internal/datadog/profiling/stack_v2/echion/echion

1 file changed

+4
-5
lines changed

ddtrace/internal/datadog/profiling/stack_v2/echion/echion/tasks.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,22 +182,21 @@ class TaskInfo
182182
PyObject* origin = NULL;
183183
PyObject* loop = NULL;
184184

185-
GenInfo::Ptr coro = nullptr;
186-
187185
StringTable::Key name;
186+
bool is_on_cpu = false;
187+
GenInfo::Ptr coro = nullptr;
188188

189189
// Information to reconstruct the async stack as best as we can
190190
TaskInfo::Ptr waiter = nullptr;
191-
bool is_on_cpu = false;
192191

193192
[[nodiscard]] static Result<TaskInfo::Ptr> create(TaskObj*);
194193
TaskInfo(PyObject* origin, PyObject* loop, GenInfo::Ptr coro, StringTable::Key name, TaskInfo::Ptr waiter)
195194
: origin(origin)
196195
, loop(loop)
197-
, coro(std::move(coro))
198196
, name(name)
197+
, is_on_cpu(coro && coro->is_running)
198+
, coro(std::move(coro))
199199
, waiter(std::move(waiter))
200-
, is_on_cpu(this->coro && this->coro->is_running)
201200
{
202201
}
203202

0 commit comments

Comments
 (0)