stats: add option for percentiles to be emitted by client for distribution metrics #41
Conversation
- Add option to control which percentiles for distribution metrics are calculated on the the client and to be emitted as a gauge Fixes DataDog#17
gbbr
changed the title
gbbr
left a comment
gbbr
left a comment
There was a problem hiding this comment.
Thanks for this! I'm sure it will be well received. Someone from our metrics team should hopefully review this more thoroughly soon.
test name from percentile)
|
@bbassingthwaite-va thank you for addressing those comments. We'll have to wait for someone from the metrics team to do a proper review of the functionality. I have notified the team and hopefully someone will do that soon. If not, feel free to ping me again and I'm happy to ping it forward :) |
- Change how percentiles are configured - Change metric suffix
- Configure using strings to remain consistent with other datadog config apis
- Change standard deviation to 1 and change comparison of expected and got to be within a given threshold - Link to the cumulative standard table to verify tests
|
Thanks again for what has been in this PR. This feature has been discussed with our teams but we need some further explorations about this feature. So, at the moment, this PR will be set on hold, but we will to provide an update as soon as possible. |
|
@AlexandreYang hi, is there any progress on this feature? this is a blocker for us. what does datadog propose as a workaround for this issue #17 ? |
|
@codesuki Apologies for late reply. This is among the things we are going to work on in the coming days. Will post here progress on the topic. |
|
There is a separate PR for disabling Counts Per Buckets: #52 cc @btbernheim |
4 participants
Datadog doesn't support Distribution metrics at the API layer, this PR introduces the ability for each client to calculate the percentiles locally and emit them as a gauge metric. This PR also adds an option to disable emitting Counts Per Buckets which for us is not useful and is quite expensive due to the number of tags that are emitted.
Fixes #17