diff --git a/.eslintrc b/.eslintrc index c4ca0a649..732b59dcd 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,9 +1,10 @@ { "plugins": ["jest", "jsx-a11y"], "extends": [ - "@doist/eslint-config/recommended-requiring-type-checking", + "@doist/eslint-config/recommended-type-checked", "@doist/eslint-config/react", - "plugin:jest/recommended" + "plugin:jest/recommended", + "@doist/eslint-config/simple-import-sort" ], "parser": "@typescript-eslint/parser", "parserOptions": { @@ -12,7 +13,7 @@ "impliedStrict": true }, "sourceType": "module", - "project": ["tsconfig.json", "tsconfig.stories.json"] + "project": ["tsconfig.json", "stories/tsconfig.json"] }, "ignorePatterns": [ "dist/**", @@ -28,7 +29,12 @@ "import/no-default-export": "off", // Legacy API. "react/no-find-dom-node": "off", "@typescript-eslint/explicit-module-boundary-types": "off", - "@typescript-eslint/ban-ts-comment": "off" + "@typescript-eslint/ban-ts-comment": "off", + + // Resolving jsx-runtime mismatched versions of React (e.g. v17 vs v18) + // See https://github.com/Doist/reactist/pull/979 + "no-restricted-imports": "off" + }, "overrides": [ { diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index dd37702c6..9874a91c3 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -10,19 +10,19 @@ Our [README](../README.md) should contain all information to get you started. If Do you want to work on an existing issue? -- Leave a comment on the issue saying that you start working on it. +- Leave a comment on the issue saying that you start working on it. Do you want to add a new component? -- Create an issue describing the component and we'll tell you whether it's a good fit for Reactist (most of them will be so don't be shy 😊). After that you can start working on it. +- Create an issue describing the component and we'll tell you whether it's a good fit for Reactist (most of them will be so don't be shy 😊). After that you can start working on it. Did you find a bug or a component not behaving as expected? -- Create an issue describing the problem. Either we will fix this or give you the opportunity (and help) to fix it yourself. +- Create an issue describing the problem. Either we will fix this or give you the opportunity (and help) to fix it yourself. Any other question / feedback? -- Open an issue and let us know :) +- Open an issue and let us know :) ## Struggling during development or need help? diff --git a/.github/ISSUE_TEMPLATE/Bug.md b/.github/ISSUE_TEMPLATE/Bug.md index bc389c056..15b34a8b5 100644 --- a/.github/ISSUE_TEMPLATE/Bug.md +++ b/.github/ISSUE_TEMPLATE/Bug.md @@ -31,6 +31,6 @@ If possible, describe how this bug could be fixed. Consider adding any relevant environment information here. --> -- `@doist/reactist` version: -- `react` version: -- Browser: +- `@doist/reactist` version: +- `react` version: +- Browser: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 07f9cc97b..8ac9efebb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,9 +16,9 @@ Please describe your implementation and any details that we should keep in mind Feel free to leave unchecked or remove the lines that are not applicable. --> -- [ ] Added tests for bugs / new features -- [ ] Updated docs (storybooks, readme) -- [ ] Reviewed and approved Chromatic visual regression tests in CI +- [ ] Added tests for bugs / new features +- [ ] Updated docs (storybooks, readme) +- [ ] Reviewed and approved Chromatic visual regression tests in CI