Show error message when dependencies aren't met.

Co-authored-by: Brian Dukes <[email protected]>
Co-authored-by: Daniel Bolef <[email protected]>

DotNetNuke.BulkInstall/DotNetNuke.BulkInstall.DeployClient.Tests/RendererTests.cs

Author: EShrestha

DotNetNuke.BulkInstall/DotNetNuke.BulkInstall.DeployClient.Tests/RendererTests.cs

@@ -315,6 +315,7 @@ public void RenderInstallationOverview_DisplaysDnnPlatformVersionDependency(LogL
                     {
                         new() { PackageName = "09.01.02", DependencyVersion = string.Empty, IsPackageDependency = false, },
                     },
+                    CanInstall = true,
                 },
             },
         };
@@ -341,6 +342,7 @@ public void RenderInstallationOverview_WhenDependencyHasNoVersion_DisplaysDepend
                     {
                         new() { PackageName = "DNNJWT", DependencyVersion = string.Empty, IsPackageDependency = true, },
                     },
+                    CanInstall = true,
                 },
             },
         };
@@ -367,6 +369,8 @@ public void RenderInstallationOverview_LogLevelAboveInformation_DoesNotRender(Lo
                     {
                         new() { PackageName = "DNNJWT", DependencyVersion = string.Empty, IsPackageDependency = true, },
                     },
+                    CanInstall = true,
+
                 },
             },
         };
@@ -387,13 +391,15 @@ public void RenderInstallationStatus_OnlyOutputsAttemptedSessionResponses(LogLev
             Name = "Jimmy",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         var james = new SessionResponse
         {
             Name = "James",
             Attempted = false,
             Success = false,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 1, jimmy }, { 2, james }, });
@@ -413,19 +419,54 @@ public void RenderInstallationStatus_OutputsMultipleResponsesOnDifferentLines(Lo
             Name = "Jimmy",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         var james = new SessionResponse
         {
             Name = "James",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 1, jimmy }, { 2, james }, });
         console.Output.ShouldContainStringsInOrder("✅", "Jimmy", "Succeeded", "\n", "✅", "James", "Succeeded", "\n");
     }
 
+    [MemberData(nameof(LogLevelsLessThanOrEqualTo), LogLevel.Information)]
+    [Theory]
+    public void RenderInstallationStatus_WhenNotSuccessfulButNoFailures_ShowsThatPackageFailed(LogLevel logLevel)
+    {
+        var packages = new SortedList<int, SessionResponse?>
+        {
+            {
+                0,
+                new SessionResponse
+                {
+                    CanInstall = false,
+                    Name = "Jamestown.zip",
+                    Failures = new List<string?>(0),
+                    Attempted = true,
+                    Success = false,
+                    Packages = new List<PackageResponse?>
+                    {
+                        new PackageResponse { Name = "James: Town", CanInstall = false, VersionStr = "1.2.3", Dependencies = new List<DependencyResponse?>(1) { new DependencyResponse { DependencyVersion = string.Empty, IsPackageDependency = true, PackageName = "Miss Sing" }, }, },
+                    },
+                }
+            },
+        };
+
+        var console = new TestConsole().Interactive();
+        var renderer = new Renderer(console);
+        renderer.RenderInstallationStatus(logLevel, packages);
+
+        console.Output.ShouldContainStringsInOrder(
+            "❌",
+            "Jamestown.zip",
+            "Failed");
+    }
+
     [MemberData(nameof(LogLevelsGreaterThanOrEqualTo), LogLevel.Warning)]
     [Theory]
     public void RenderInstallationStatus_ShouldNotRenderWarningOrHigher(LogLevel logLevel)
@@ -438,13 +479,15 @@ public void RenderInstallationStatus_ShouldNotRenderWarningOrHigher(LogLevel log
             Name = "Jimmy",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         var james = new SessionResponse
         {
             Name = "James",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 1, jimmy }, { 2, james }, });
@@ -463,13 +506,15 @@ public void RenderInstallationStatus_DoesNotOutputDuplicateInformation(LogLevel
             Name = "James",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         var george = new SessionResponse
         {
             Name = "George",
             Attempted = false,
             Success = false,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 2, james }, { 3, george }, });
@@ -492,13 +537,15 @@ public void RenderInstallationStatus_WhenErrorLevel_DoesNotOutputInformationLeve
             Name = "James",
             Attempted = true,
             Success = true,
+            CanInstall = true,
         };
 
         var george = new SessionResponse
         {
             Name = "George",
             Attempted = false,
             Success = false,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 2, james }, { 3, george }, });
@@ -521,6 +568,7 @@ public void RenderInstallationStatus_OutputsMessageWhenPackageIsSuccessful(LogLe
             Name = "James",
             Attempted = false,
             Success = false,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 2, james }, });
@@ -542,13 +590,15 @@ public void RenderInstallationStatus_RendersFailures(LogLevel logLevel)
             Name = "Jimmy",
             Attempted = true,
             Failures = new List<string?> { "BAD ZIP", "REALLY FAILED", },
+            CanInstall = true,
         };
 
         var james = new SessionResponse
         {
             Name = "James",
             Attempted = true,
             Success = false,
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 1, jimmy }, { 2, james }, });
@@ -568,6 +618,7 @@ public void RenderInstallationStatus_FailuresHaveSpectreMarkup_RendersFailures(L
             Name = "Jimmy",
             Attempted = true,
             Failures = new List<string?> { "Failed SQL Query", "SELECT [Name] FROM Place", },
+            CanInstall = true,
         };
 
         renderer.RenderInstallationStatus(logLevel, new SortedList<int, SessionResponse?> { { 1, jimmy }, });

DotNetNuke.BulkInstall/DotNetNuke.BulkInstall.DeployClient/Renderer.cs

@@ -228,12 +228,25 @@ public void RenderInstallationStatus(LogLevel level, SortedList<int, SessionResp
                 this.succeededPackageFiles.Add(file.Name);
             }
 
-            if (file.Failures?.Any() == true && !this.failedPackageFiles.Contains(file.Name))
+            if ((file.Failures?.Any() == true || !file.CanInstall) && !this.failedPackageFiles.Contains(file.Name))
             {
                 if (level <= LogLevel.Error)
                 {
                     var failureTree = new Tree(Markup.FromInterpolated($":cross_mark: [aqua]{file.Name}[/] [red]Failed[/]"));
-                    failureTree.AddNodes(file.Failures.Where(f => f != null).Select(f => new Text(f!)));
+
+                    if (file.Failures?.Any() == true)
+                    {
+                        failureTree.AddNodes(file.Failures.Where(f => f != null).Select(f => new Text(f!)));
+                    }
+                    else
+                    {
+                        failureTree.AddNode("Can't install some packages, check their dependencies");
+                        if (file.Packages != null)
+                        {
+                            failureTree.AddNodes(file.Packages.Where(p => p?.CanInstall == false).Select(p => Markup.FromInterpolated($"Unable to install [aqua]{p!.Name}[/]")));
+                        }
+                    }
+
                     this.console.Write(failureTree);
                 }