Add mnemonics for better experience #655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastoner
force-pushed
the
Mnemonics
branch
2 times, most recently
from
eb35f02 to
c7af1e9
Compare
Collaborator
|
This is actually mixing two changes, thus making it harder to review. I would prefer to split it into two commits at least, where one adds mnemonics and one improves code readability. Two separate PRs would be even better,. |
gastoner
force-pushed
the
Mnemonics
branch
3 times, most recently
from
70cc935 to
a9d3d23
Compare
Collaborator
|
This is for sure going to break some translations. I checked how mnemonics are used in KDE and GNOME and both show underscores only when "alt" button is pressed so I believe we should be consistent here, but currently have no idea how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643