Allow using s3 storage when self_hosted=true #1458
Open
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for the great software.
I run kubernetes at a large scale in my homelab and I prefer to use s3 object storage whenever possible instead of volumes. I saw that Dawarich supports s3 storage, but only when running as a SaaS (self_hosted=false). I have tested out the s3 support in my homelab and it seems to work well, so I would like the ability to use s3 storage without losing the features that self_hosted=true gives me.
This pull request adds the ability to set the STORAGE_BACKEND, to enable s3 storage, independent of SELF_HOSTED.
I have never coded in ruby before, so please let me know if my code has any mistakes.