ContentBlocksDataProcessor throws error if used in menus on translated pages

[viu-x]

Describe the bug
If you want to use the ContentBlocksDataProcessor on a menu like it throws the following error if you visit a translated page. It does not matter if it is normal page type or a custom one created through content blocks.

TYPO3\CMS\Core\Domain\Record\ComputedProperties::__construct(): Argument #4 ($translationSource) must 
be of type ?TYPO3\CMS\Core\Domain\Page, array given, called in 
/var/www/html/vendor/typo3/cmscore/Classes/Domain/RecordFactory.php on line 208

To Reproduce

1. Create a translated page
2. Create a menu with data processor

page = PAGE
page {
    10 = FLUIDTEMPLATE
    10 {
        dataProcessing {
            40 = menu
            40 {
                levels = 3
                includeSpacer = 1
                as = navigationMain
                dataProcessing.10 = content-blocks
            }
        }
        // ...
    }
}

3. Visit the translated page
4. See error message above

Expected behavior
The data processor behaves exactly like on the default language.

TYPO3 Version
13.4.18

Content Blocks Version:
Latest

[nhovratov]

Thanks, I think this is an issue in Core. I will inform the resposible Core devs.

[georgringer]

that cost me 2h to debug. culprit is the ugly menu processor using json_encode which looses the object

diff --git a/typo3/sysext/core/Classes/Domain/RecordFactory.php b/typo3/sysext/core/Classes/Domain/RecordFactory.php
index 429b4fec858..62515d39b7c 100644
--- a/typo3/sysext/core/Classes/Domain/RecordFactory.php
+++ b/typo3/sysext/core/Classes/Domain/RecordFactory.php
@@ -205,6 +205,9 @@ readonly class RecordFactory
 
     protected function extractComputedProperties(array &$record): ComputedProperties
     {
+        if (is_array($record['_TRANSLATION_SOURCE'])) {
+            $record['_TRANSLATION_SOURCE'] = new Page($record['_TRANSLATION_SOURCE']);
+        }
         $computedProperties = new ComputedProperties(
             $record['_ORIG_uid'] ?? null,
             $record['_LOCALIZED_UID'] ?? null,
diff --git a/typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php b/typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php
index 9413656c76e..722d0c1da6c 100644
--- a/typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php
+++ b/typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php
@@ -15,6 +15,7 @@
 
 namespace TYPO3\CMS\Frontend\DataProcessing;
 
+use TYPO3\CMS\Core\Domain\Page;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\ContentObject\ContentDataProcessor;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectFactory;
@@ -518,6 +519,9 @@ class MenuProcessor implements DataProcessorInterface
      */
     public function jsonEncode($value)
     {
+        if (is_array($value) && $value['_TRANSLATION_SOURCE'] instanceof Page) {
+            $value['_TRANSLATION_SOURCE'] = $value['_TRANSLATION_SOURCE']->toArray(true);
+        }
         return json_encode($value, JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_QUOT | JSON_HEX_AMP | JSON_UNESCAPED_UNICODE);
     }
 

absolutly no clue how this can be done right