Use '0' instead of '1' as TCA default type definition key

[georg-tiefenbrunn]

I recently stumbled into a 'Type value 0 from database record not defined in TCA' exception after importing records into a ContentBlocks/RecordTypes table using multiple types.

While fixing the issue I noticed that CB currently uses 1 as TCA default type, but TYPO3 nowadays uses 0:

TCA Reference

At least one type has to be configured before any field will show up, the default type is 0.

EXT:backend/Classes/Form/FormDataProvider/DatabaseRecordTypeValue.php

        if (empty($result['processedTca']['types'][$recordTypeValue])
            && empty($result['processedTca']['types']['0'])
            && empty($result['processedTca']['types']['1'])
        ) {
...
        // Check the determined value actually exists as types key, otherwise fall back to 0 or 1, 1 for "historical reasons"
        if (empty($result['processedTca']['types'][$recordTypeValue])) {
            $recordTypeValue = !empty($result['processedTca']['types']['0']) ? '0' : '1';
        }

Affected Code

• TYPO3\CMS\ContentBlocks\Definition\TableDefinition->getDefaultTypeDefinition() only checks for type 1
• TYPO3\CMS\ContentBlocks\Loader\ContentBlockLoader->createTypeName() always returns 1 for records without typeName definition
• Comment in TYPO3\CMS\ContentBlocks\Generator\TcaGenerator->fillTypeFieldSelectItems() (the default type "1")
• TYPO3\CMS\ContentBlocks\Definition\Factory\Processing\ProcessingInput->resolveTypeName() ignores typeName definition if no typeField is defined and always returns 1

Nice to have

• CB should ensure type 0 exists (copy the default type definition) so you don't have to use typeName: 0 for the record definition with highest priority.

[nhovratov]

@georg-tiefenbrunn It doesn't matter if using "0" or "1". This is historical and both work as the default type. As we went with "1", changing it now would be breaking.

[nhovratov]

Can you show me an example, where this actually leads to a problem?

If I understand you correctly, the problem was you forgot to set a typeName for the RecordType. But it doesn't need to be "0" for the default type (maybe you don't even have a default and all types are equal). It can be anything you want. The type "0" is only relevant for a) Single Type Records, which only have one type (=aka default type "0" or "1"). Or b) For Multi-Type Records, if the record type could not be resolved => Then this acts as a fallback type. For example the tt_content table has this as a fallback type: https://github.com/TYPO3/typo3/blob/76c6c3eb3c24107b918349dcbd1c572baef420b7/typo3/sysext/frontend/Configuration/TCA/tt_content.php#L588-L590

Another thing: In case you are changing an existing single type record to a multi type, then you need to update the database with the new default type (typeName), or else exactly the problem from above arises.

[bmack]

Hey @nhovratov what do you think about this one? https://review.typo3.org/c/Packages/TYPO3.CMS/+/89581

[nhovratov]

Hey @nhovratov what do you think about this one? https://review.typo3.org/c/Packages/TYPO3.CMS/+/89581

@bmack This would at least introduce a definite "default" type, replacing the cryptic numbers. But of course there could already be types that use "default", so I don't know how breaking that would be.