Fix trek's ambiance translations not emptied by ApidaeTrekParser (#5055)

Author: justinefricou

docs/changelog.rst

@@ -5,6 +5,10 @@ CHANGELOG
 2.120.1+dev     (XXXX-XX-XX)
 ----------------------------
 
+**Bug fixes**
+
+* Fix trek's ``ambiance`` translated fields not being emptied by ApidaeTrekParser when the source data does not contain corresponding translations
+
 
 2.120.1         (2025-10-22)
 ----------------------------

geotrek/trekking/parsers.py

@@ -543,7 +543,6 @@ class ApidaeTrekParser(AttachmentParserMixin, ApidaeBaseTrekkingParser):
         "labels": {"create": True},
         "name": {"expand_translations": True},
         "description_teaser": {"expand_translations": True},
-        "ambiance": {"expand_translations": True},
         "access": {"expand_translations": True},
         "difficulty": {"create": True},
         "related_treks": {"create": True},
@@ -904,6 +903,11 @@ def filter_gear(self, src, val):
             )
         return self.apply_filter(dst="gear", src=src, val=tf)
 
+    def filter_ambiance(self, src, val):
+        tf = ApidaeTranslatedField()
+        tf.append(translated_value=val)
+        return self.apply_filter(dst="ambiance", src=src, val=tf)
+
     def _finalize_related_treks_association(self):
         for parent_id, children_eids in self._related_treks_mapping.items():
             parent_trek = Trek.objects.get(pk=parent_id)

geotrek/trekking/tests/data/apidae_trek_parser/simple_trek_ambiance_fr_and_en_both_empty.json

@@ -0,0 +1,28 @@
+{
+  "numFound": 1,
+  "objetsTouristiques": [
+    {
+      "id": 123123,
+      "multimedias": [
+        {
+          "type": "PLAN",
+          "traductionFichiers": [
+            {
+              "url": "https://example.net/apidae_test_trek.gpx",
+              "extension": "gpx"
+            }
+          ]
+        }
+      ],
+      "nom": {
+        "libelleFr": "Une belle randonnée de test",
+        "libelleEn": "A great hike to test"
+      },
+      "presentation": {
+        "descriptifDetaille": {
+          "libelleEn": ""
+        }
+      }
+    }
+  ]
+}

geotrek/trekking/tests/data/apidae_trek_parser/simple_trek_ambiance_fr_and_en_not_empty.json

@@ -0,0 +1,29 @@
+{
+  "numFound": 1,
+  "objetsTouristiques": [
+    {
+      "id": 123123,
+      "multimedias": [
+        {
+          "type": "PLAN",
+          "traductionFichiers": [
+            {
+              "url": "https://example.net/apidae_test_trek.gpx",
+              "extension": "gpx"
+            }
+          ]
+        }
+      ],
+      "nom": {
+        "libelleFr": "Une belle randonnée de test",
+        "libelleEn": "A great hike to test"
+      },
+      "presentation": {
+        "descriptifDetaille": {
+          "libelleFr": "abc",
+          "libelleEn": "123"
+        }
+      }
+    }
+  ]
+}

geotrek/trekking/tests/data/apidae_trek_parser/simple_trek_ambiance_fr_not_empty_ambiance_en_empty.json

@@ -0,0 +1,28 @@
+{
+  "numFound": 1,
+  "objetsTouristiques": [
+    {
+      "id": 123123,
+      "multimedias": [
+        {
+          "type": "PLAN",
+          "traductionFichiers": [
+            {
+              "url": "https://example.net/apidae_test_trek.gpx",
+              "extension": "gpx"
+            }
+          ]
+        }
+      ],
+      "nom": {
+        "libelleFr": "Une belle randonnée de test",
+        "libelleEn": "A great hike to test"
+      },
+      "presentation": {
+        "descriptifDetaille": {
+          "libelleFr": "cba"
+        }
+      }
+    }
+  ]
+}

geotrek/trekking/tests/test_parsers.py

@@ -1345,7 +1345,7 @@ def test_trek_is_imported(self, mocked_get):
         self.assertEqual(Attachment.objects.count(), 0)
 
     @mock.patch("requests.get")
-    def test_trek_import_multiple_time(self, mocked_get):
+    def test_trek_import_multiple_times_description_is_updated(self, mocked_get):
         RouteFactory(route="Boucle")
         mocked_get.side_effect = self.make_dummy_get("a_trek.json")
 
@@ -1384,6 +1384,74 @@ def test_trek_import_multiple_time(self, mocked_get):
         self.assertEqual(old_description_en, trek.description_en)
         self.assertEqual(old_description, trek.description)
 
+    @mock.patch("requests.get")
+    def test_trek_import_multiple_times_ambiance_is_not_empty_then_updated(
+        self, mocked_get
+    ):
+        """
+        A trek is imported once. Its fields ambiance_fr and ambiance_en both have
+        a value. When importing the trek again with new source data, ambiance_fr
+        should have another value, and ambiance_en should be empty.
+        """
+        mocked_get.side_effect = self.make_dummy_get(
+            "simple_trek_ambiance_fr_and_en_not_empty.json"
+        )
+        call_command(
+            "import",
+            "geotrek.trekking.tests.test_parsers.TestApidaeTrekParser",
+            verbosity=0,
+        )
+        self.assertEqual(Trek.objects.count(), 1)
+        trek = Trek.objects.all().first()
+        self.assertEqual(trek.ambiance_fr, "abc")
+        self.assertEqual(trek.ambiance_en, "123")
+        mocked_get.side_effect = self.make_dummy_get(
+            "simple_trek_ambiance_fr_not_empty_ambiance_en_empty.json"
+        )
+        call_command(
+            "import",
+            "geotrek.trekking.tests.test_parsers.TestApidaeTrekParser",
+            verbosity=0,
+        )
+        self.assertEqual(Trek.objects.count(), 1)
+        trek = Trek.objects.all().first()
+        self.assertEqual(trek.ambiance_fr, "cba")
+        self.assertEqual(trek.ambiance_en, "")
+
+    @mock.patch("requests.get")
+    def test_trek_import_multiple_times_ambiance_is_empty_then_updated(
+        self, mocked_get
+    ):
+        """
+        A trek is imported once. Its fields ambiance_fr and ambiance_en are both
+        empty. When importing the trek again with new source data, ambiance_fr
+        should now have a value, and ambiance_en should still be empty.
+        """
+        mocked_get.side_effect = self.make_dummy_get(
+            "simple_trek_ambiance_fr_and_en_both_empty.json"
+        )
+        call_command(
+            "import",
+            "geotrek.trekking.tests.test_parsers.TestApidaeTrekParser",
+            verbosity=0,
+        )
+        self.assertEqual(Trek.objects.count(), 1)
+        trek = Trek.objects.all().first()
+        self.assertEqual(trek.ambiance_fr, "")
+        self.assertEqual(trek.ambiance_en, "")
+        mocked_get.side_effect = self.make_dummy_get(
+            "simple_trek_ambiance_fr_not_empty_ambiance_en_empty.json"
+        )
+        call_command(
+            "import",
+            "geotrek.trekking.tests.test_parsers.TestApidaeTrekParser",
+            verbosity=0,
+        )
+        self.assertEqual(Trek.objects.count(), 1)
+        trek = Trek.objects.all().first()
+        self.assertEqual(trek.ambiance_fr, "cba")
+        self.assertEqual(trek.ambiance_en, "")
+
     @mock.patch("requests.get")
     def test_trek_geometry_can_be_imported_from_gpx(self, mocked_get):
         mocked_get.side_effect = self.make_dummy_get("a_trek.json")