Fixing unnecessary mock errors which appear only on IDE runs (#2965)

Author: VardhanThigle

v2/sourcedb-to-spanner/src/test/java/com/google/cloud/teleport/v2/source/reader/io/jdbc/iowrapper/JdbcIoWrapperTest.java

@@ -21,6 +21,7 @@
 import static org.junit.Assert.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.lenient;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -204,7 +205,8 @@ public void testJdbcIoWrapperNoPrimaryKeyExistsOnTable()
                         .setIsUnique(true)
                         .setOrdinalPosition(2)
                         .build())));
-    when(mockDialectAdapter.discoverTableSchema(any(), (SourceSchemaReference) any(), any()))
+    lenient()
+        .when(mockDialectAdapter.discoverTableSchema(any(), (SourceSchemaReference) any(), any()))
         .thenReturn(ImmutableMap.of("testTable", ImmutableMap.of(testCol, testColType)));
 
     assertThrows(
@@ -298,7 +300,8 @@ public void testJdbcIoWrapperDifferentTables() throws RetriableSchemaDiscoveryEx
     SourceColumnType testColType = new SourceColumnType("INTEGER", new Long[] {}, null);
     when(mockDialectAdapter.discoverTables(any(), (SourceSchemaReference) any()))
         .thenReturn(ImmutableList.of("testTable"));
-    when(mockDialectAdapter.discoverTableIndexes(any(), (SourceSchemaReference) any(), any()))
+    lenient()
+        .when(mockDialectAdapter.discoverTableIndexes(any(), (SourceSchemaReference) any(), any()))
         .thenReturn(
             ImmutableMap.of(
                 "testTable",
@@ -312,7 +315,8 @@ public void testJdbcIoWrapperDifferentTables() throws RetriableSchemaDiscoveryEx
                         .setIsUnique(true)
                         .setOrdinalPosition(1)
                         .build())));
-    when(mockDialectAdapter.discoverTableSchema(any(), (SourceSchemaReference) any(), any()))
+    lenient()
+        .when(mockDialectAdapter.discoverTableSchema(any(), (SourceSchemaReference) any(), any()))
         .thenReturn(ImmutableMap.of("testTable", ImmutableMap.of(testCol, testColType)));
     JdbcIoWrapper jdbcIoWrapper =
         JdbcIoWrapper.of(

v2/sourcedb-to-spanner/src/test/java/com/google/cloud/teleport/v2/source/reader/io/jdbc/uniformsplitter/range/BoundaryExtractorFactoryTest.java

@@ -268,9 +268,8 @@ public void testFromTimestampsEmptyTable() throws SQLException {
         PartitionColumn.builder().setColumnName("col1").setColumnClass(Timestamp.class).build();
     BoundaryExtractor<Timestamp> extractor = BoundaryExtractorFactory.create(Timestamp.class);
     when(mockResultSet.next()).thenReturn(true);
-    when(mockResultSet.getBigDecimal(1)).thenReturn(null);
-    // BigInt Unsigned Max in MySQL
-    when(mockResultSet.getBigDecimal(2)).thenReturn(null);
+    when(mockResultSet.getTimestamp(eq(1), any())).thenReturn(null);
+    when(mockResultSet.getTimestamp(eq(2), any())).thenReturn(null);
     Boundary<Timestamp> boundary = extractor.getBoundary(partitionColumn, mockResultSet, null);
 
     assertThat(boundary.start()).isNull();

v2/sourcedb-to-spanner/src/test/java/com/google/cloud/teleport/v2/source/reader/io/schema/SchemaDiscoveryImplTest.java

@@ -54,7 +54,6 @@ public class SchemaDiscoveryImplTest {
   public void testSchemaDiscoveryImpl() throws RetriableSchemaDiscoveryException {
     final int testRetryCount = 2;
     final int expectedCallsCount = testRetryCount + 1;
-    when(mockDataSource.jdbc()).thenReturn(mockJdbcDataSource);
     when(mockRetriableSchemaDiscovery.discoverTableSchema(
             mockDataSource, mockSourceSchemaReference, ImmutableList.of()))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()))
@@ -82,7 +81,6 @@ public void testSchemaDiscoveryImplThrowsRetriesExhausted()
 
     when(mockFluentBackoff.backoff()).thenReturn(mockBackoff);
     when(mockBackoff.nextBackOffMillis()).thenThrow(new RuntimeException("test"));
-    when(mockDataSource.jdbc()).thenReturn(mockJdbcDataSource);
     when(mockRetriableSchemaDiscovery.discoverTableSchema(
             mockDataSource, mockSourceSchemaReference, ImmutableList.of()))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()));
@@ -103,7 +101,6 @@ public void testSchemaDiscoveryImplHandlesIOException()
 
     final int testRetryCount = 2;
     final int expectedCallsCount = testRetryCount + 1;
-    when(mockDataSource.jdbc()).thenReturn(mockJdbcDataSource);
     when(mockRetriableSchemaDiscovery.discoverTableSchema(
             mockDataSource, mockSourceSchemaReference, ImmutableList.of()))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()));
@@ -128,7 +125,6 @@ public void testTableDiscoveryImpl() throws RetriableSchemaDiscoveryException {
     final int testRetryCount = 2;
     final int expectedCallsCount = testRetryCount + 1;
     final ImmutableList<String> testTables = ImmutableList.of("testTable1", "testTable2");
-    when(mockDataSource.jdbc()).thenReturn(mockJdbcDataSource);
     when(mockRetriableSchemaDiscovery.discoverTables(mockDataSource, mockSourceSchemaReference))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()))
@@ -162,7 +158,7 @@ public void testIndexDiscoveryImpl() throws RetriableSchemaDiscoveryException {
                     .setOrdinalPosition(1)
                     .setIndexType(IndexType.NUMERIC)
                     .build()));
-    when(mockDataSource.jdbc()).thenReturn(mockJdbcDataSource);
+
     when(mockRetriableSchemaDiscovery.discoverTableIndexes(
             mockDataSource, mockSourceSchemaReference, ImmutableList.of("testTable1")))
         .thenThrow(new RetriableSchemaDiscoveryException(new SQLTransientConnectionException()))