Skip to content

Commit 609660b

Browse files
committed
remove irrelevant assertions from test
1 parent 8b1f7e2 commit 609660b

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

postgres/src/lib.rs

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -641,34 +641,23 @@ mod test {
641641
let storage = PostgresStorage::new(connection_string).await?;
642642

643643
// Clients 1 and 2 do not interfere with each other; if these are the same client, then
644-
// this will deadlock as one transaction waits for the other.
644+
// this will deadlock as one transaction waits for the other. If the postgres storage
645+
// implementation serialized _all_ transactions across clients, that would limit its
646+
// scalability.
647+
//
648+
// So the asertion here is "does not deadlock".
649+
645650
let client_id1 = make_client(&db_client).await?;
646651
let mut txn1 = storage.txn(client_id1).await?;
647652
let version_id1 = Uuid::new_v4();
648653
txn1.add_version(version_id1, Uuid::nil(), b"v1".to_vec())
649654
.await?;
650-
assert_eq!(
651-
txn1.get_version(version_id1).await?,
652-
Some(Version {
653-
version_id: version_id1,
654-
parent_version_id: Uuid::nil(),
655-
history_segment: b"v1".to_vec()
656-
})
657-
);
658655

659656
let client_id2 = make_client(&db_client).await?;
660657
let mut txn2 = storage.txn(client_id2).await?;
661658
let version_id2 = Uuid::new_v4();
662659
txn2.add_version(version_id2, Uuid::nil(), b"v2".to_vec())
663660
.await?;
664-
assert_eq!(
665-
txn2.get_version(version_id2).await?,
666-
Some(Version {
667-
version_id: version_id2,
668-
parent_version_id: Uuid::nil(),
669-
history_segment: b"v2".to_vec()
670-
})
671-
);
672661

673662
txn1.commit().await?;
674663
txn2.commit().await?;

0 commit comments

Comments
 (0)