Request hook #5433
Open
Request hook #5433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
reviewed
Oct 28, 2025
| */ | ||
| final public static function postDispatch(Request $request): void | ||
| { | ||
| array_map( |
Member
There was a problem hiding this comment.
Why array_map? You don't use its result.
Add a hook that hooks into different states of a request. The implementation starts with hooking into after non xhr requests are dispatched. This is meant to be extended for more more states like before a request gets dispatched.
Ensuring the request is no xhr request.
Al2Klimov
reviewed
Nov 4, 2025
| if ($this->isXhr()) { | ||
| $this->postDispatchXhr(); | ||
| } else { | ||
| RequestHook::postDispatch($req); |
Member
There was a problem hiding this comment.
I think letting the hook decide would be clever AND smart. I mean, anyone could provide a hook... and wonder why some requests are missing. If $this->isXhr() is too heavy just with $req, we can pass additional arguments like a bool.
Member
There was a problem hiding this comment.
I already discussed this w/ @jrauh01. We will call postDispatch() unconditionally.
Member
There was a problem hiding this comment.
@jrauh01 Please also add the following to our Request:
public function isAutoRefresh(): bool
{
return $this->getHeader('X-Icinga-Autorefresh');
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
RequestHookthat hooks into different states of a request. The implementation starts with hooking into after non xhr requests are dispatched. This is meant to be extended for more more states like for example before a request gets dispatched.