Merge pull request #23 from Icinga/do-not-mutate-property-when-setting-it

Properties: Don't mutate properties when setting them

Author: nilmerg

src/Properties.php

@@ -11,14 +11,24 @@
 trait Properties
 {
     /** @var array */
-    protected $properties = [];
+    private $properties = [];
 
     /** @var array */
-    protected $mutatedProperties = [];
+    private $mutatedProperties = [];
 
     /** @var bool Whether accessors and mutators are enabled */
     protected $accessorsAndMutatorsEnabled = false;
 
+    /**
+     * Get whether this class has any properties
+     *
+     * @return bool
+     */
+    public function hasProperties()
+    {
+        return ! empty($this->properties);
+    }
+
     /**
      * Get whether a property with the given key exists
      *
@@ -95,10 +105,6 @@ protected function setProperty($key, $value)
     {
         $this->properties[$key] = $value;
 
-        if ($this->accessorsAndMutatorsEnabled) {
-            $this->mutateProperty($key);
-        }
-
         return $this;
     }
 
@@ -117,7 +123,7 @@ protected function mutateProperty($key)
         $value = array_key_exists($key, $this->properties)
             ? $this->properties[$key]
             : null;
-        $this->mutatedProperties[$key] = $value; // Prevents repeated checks
+        $this->mutatedProperties[$key] = true; // Prevents repeated checks
 
         $mutator = Str::camel('mutate_' . $key) . 'Property';
         if (method_exists($this, $mutator)) {