bug: fix user defaults migration issues.

Author: JerryZLiu

Dayflow/Dayflow/App/AppDelegate.swift

@@ -24,6 +24,11 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     private var pendingDeepLinkURLs: [URL] = []
     private var pendingRecordingAnalyticsReason: String?
 
+    override init() {
+        UserDefaultsMigrator.migrateIfNeeded()
+        super.init()
+    }
+
     func applicationDidFinishLaunching(_ note: Notification) {
         // Block termination by default; only specific flows enable it.
         AppDelegate.allowTermination = false

Dayflow/Dayflow/Models/TimelineCategory.swift

@@ -172,11 +172,8 @@ final class CategoryStore: ObservableObject {
 
     private func load() {
         let decoded = CategoryPersistence.loadPersistedCategories()
-        if decoded.isEmpty {
-            categories = CategoryPersistence.defaultCategories
-        } else {
-            categories = CategoryPersistence.ensureIdleCategoryPresent(in: decoded)
-        }
+        let effective = decoded.isEmpty ? CategoryPersistence.defaultCategories : decoded
+        categories = CategoryPersistence.ensureIdleCategoryPresent(in: effective)
     }
 
     private func save() {

Dayflow/Dayflow/Utilities/UserDefaultsMigrator.swift

@@ -2,9 +2,12 @@ import Foundation
 
 enum UserDefaultsMigrator {
     private static let sentinelKey = "didMigrateFromSandboxDefaults"
+    private static let skippedKeyPrefixes = ["NS", "Apple", "AV", "SU"]
 
-    static func migrateIfNeeded() {
-        let defaults = UserDefaults.standard
+    static func migrateIfNeeded(
+        defaults: UserDefaults = .standard,
+        fileManager: FileManager = .default
+    ) {
         if defaults.bool(forKey: sentinelKey) {
             return
         }
@@ -14,53 +17,37 @@ enum UserDefaultsMigrator {
             return
         }
 
-        let fileManager = FileManager.default
-        let containerPlist = fileManager.homeDirectoryForCurrentUser
+        let containerPlistURL = fileManager.homeDirectoryForCurrentUser
             .appendingPathComponent("Library/Containers/\(bundleId)/Data/Library/Preferences/\(bundleId).plist")
-        let targetPlist = fileManager.homeDirectoryForCurrentUser
-            .appendingPathComponent("Library/Preferences/\(bundleId).plist")
 
-        guard fileManager.fileExists(atPath: containerPlist.path) else {
+        guard fileManager.fileExists(atPath: containerPlistURL.path) else {
             defaults.set(true, forKey: sentinelKey)
             return
         }
 
-        do {
-            if fileManager.fileExists(atPath: targetPlist.path) {
-                let backup = targetPlist.appendingPathExtension("preMigration")
-                do {
-                    try? fileManager.removeItem(at: backup)
-                    try fileManager.moveItem(at: targetPlist, to: backup)
-                } catch {
-                    print("⚠️ UserDefaultsMigrator: failed to back up existing defaults: \(error)")
-                }
-            }
-
-            if fileManager.fileExists(atPath: targetPlist.path) {
-                try fileManager.removeItem(at: targetPlist)
-            }
-
-            try fileManager.copyItem(at: containerPlist, to: targetPlist)
-            if let migratedDefaults = NSDictionary(contentsOf: targetPlist) as? [String: Any] {
-                var mergedDefaults = defaults.persistentDomain(forName: bundleId) ?? [:]
-                var didMerge = false
+        guard let legacyDomain = NSDictionary(contentsOf: containerPlistURL) as? [String: Any], legacyDomain.isEmpty == false else {
+            defaults.set(true, forKey: sentinelKey)
+            return
+        }
 
-                for (key, value) in migratedDefaults where mergedDefaults[key] == nil {
-                    mergedDefaults[key] = value
-                    didMerge = true
-                }
+        let filteredLegacy = legacyDomain.filter { key, _ in
+            guard key != sentinelKey else { return false }
+            return skippedKeyPrefixes.contains { prefix in key.hasPrefix(prefix) } == false
+        }
 
-                if didMerge {
-                    // Hydrate missing keys so callers see the migrated values without clobbering newer writes.
-                    defaults.setPersistentDomain(mergedDefaults, forName: bundleId)
-                }
-            } else {
-                print("⚠️ UserDefaultsMigrator: failed to hydrate migrated defaults from \(targetPlist.path)")
-            }
+        if filteredLegacy.isEmpty {
             defaults.set(true, forKey: sentinelKey)
-            print("UserDefaultsMigrator: copied sandbox defaults to \(targetPlist.path)")
-        } catch {
-            print("⚠️ UserDefaultsMigrator: failed to migrate defaults: \(error)")
+            return
+        }
+
+        var mergedDomain = defaults.persistentDomain(forName: bundleId) ?? [:]
+        for (key, value) in filteredLegacy {
+            mergedDomain[key] = value
         }
+
+        defaults.setPersistentDomain(mergedDomain, forName: bundleId)
+        defaults.set(true, forKey: sentinelKey)
+
+        print("UserDefaultsMigrator: migrated \(filteredLegacy.count) keys from sandbox defaults")
     }
 }

Dayflow/Dayflow/Views/Onboarding/LLMProviderSetupView.swift

@@ -508,7 +508,7 @@ struct LLMProviderSetupView: View {
                 )
 
                 VStack(alignment: .leading, spacing: 12) {
-                    Text("Choose your Gemini model")
+                    Text("Choose your Gemini model. If you're on the free tier, pick 2.5 Pro, it's the most powerful model and is completely free to use. If you're on a paid plan, which is not recommended, I recommend 2.5 Flash-Lite to minimize costs.")
                         .font(.custom("Nunito", size: 16))
                         .fontWeight(.semibold)
                         .foregroundColor(.black.opacity(0.85))