-
Notifications
You must be signed in to change notification settings - Fork 115
Open
Description
The WelchConfig docstring has an interesting nugget:
Lines 545 to 549 in d08699a
| !!! note | |
| WelchConfig precomputes an fft plan, and preallocates the necessary intermediate buffers. | |
| Thus, repeated calls to `welch_pgram` that use the same `WelchConfig` object | |
| will be more efficient than otherwise possible. |
The latter part encourages re-use, but the former part hints that concurrent re-use may have a race condition. It might be useful to call this out explicitly so that a naive
config = WelchConfig(...)
psds = Vector{Periodogram}(undef, length(signals))
Threads.@threads for (idx, sig) in enumerate(signals)
psds[idx] = welch_pgram(sig, config)
enddoesn't become a user footgun
Metadata
Metadata
Assignees
Labels
No labels