Test for the bug patch in #177 (#179)

* fix basins

* only change the output basins, not the mapper state

* change patch number

* fix doc compiling errors

* add test

* fix test

* move test

Author: awage

Project.toml

@@ -2,7 +2,7 @@ name = "Attractors"
 uuid = "f3fd9213-ca85-4dba-9dfd-7fc91308fec7"
 authors = ["George Datseris <[email protected]>", "Kalel Rossi", "Alexandre Wagemakers"]
 repo = "https://github.com/JuliaDynamics/Attractors.jl.git"
-version = "1.26.3"
+version = "1.26.4"
 
 
 [deps]

docs/make.jl

@@ -28,6 +28,13 @@ pages = [
     Documenter.hide("recurrences_animation.md"),
 ]
 
+size_threshold_ignore = [
+    "tutorial.md",
+    "api.md",
+    "examples.md",
+    "references.md",
+]
+
 import Downloads
 Downloads.download(
     "https://raw.githubusercontent.com/JuliaDynamics/doctheme/master/build_docs_with_style.jl",
@@ -44,4 +51,5 @@ bib = CitationBibliography(
 
 build_docs_with_style(pages, Attractors, StateSpaceSets;
     expandfirst = ["index.md"], bib, warnonly = [:doctest, :missing_docs, :cross_references],
+    htmlkw = (;size_threshold_ignore)
 )

docs/refs.bib

@@ -295,6 +295,10 @@ @article{Krakovska2024ResilienceDynamicalSystems
 @article{Morr2025,
   title = {To be published},
   author = {Andreas Morr, George Datseris},
+  journal = {},
+  volume = {},
+  number = {},
+  pages = {},
   year = {2025},
 }
 

test/mapping/attractor_mapping.jl

@@ -71,6 +71,8 @@ function test_basins(ds, u0s, grid, expected_fs_raw, featurizer;
         test_basins_fractions(mapper; err = rerr)
     end
 
+
+
     @testset "Featurizing, clustering" begin
         optimal_radius_method = "silhouettes_optim"
         config = GroupViaClustering(; num_attempts_radius=20, optimal_radius_method)
@@ -330,3 +332,27 @@ if DO_EXTENSIVE_TESTS
     end
 
 end
+
+@testset "Basins of Attraction" begin 
+    # The reason of this test is to check whether 
+    # basins_of_attraction does not modify the internal 
+    # state of the mapper changing. (regression bug)
+    function map_3_states(z, p, n)
+        if z[1] < -1
+            return SVector(-2.0, 0.) 
+        elseif -1 ≤ z[1] ≤ 1
+            return SVector(0.0, 0.)
+        else 
+            return SVector(2.0, 0.)
+        end
+    end
+    ds = DiscreteDynamicalSystem(map_3_states, zeros(2)) 
+    xg = yg = range(-3, 3; length = 20) 
+    grid = (xg, yg)
+    mapper = AttractorsViaRecurrences(ds, grid; sparse = false)  
+    basins, atts = basins_of_attraction(mapper; show_progress = false)
+    ics = [ [x,1.0] for x in range(-3,3,length = 20)]
+    fractions, labels = basins_fractions(mapper, ics)
+
+    @test 0 ∉ keys(fractions)
+end