Skip to content

Conversation

@yashvardhan747
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #35   +/-   ##
======================================
  Coverage    67.9%   67.9%           
======================================
  Files           4       4           
  Lines          81      81           
======================================
  Hits           55      55           
  Misses         26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b364c38...c88fe9d. Read the comment docs.

@dpsanders
Copy link
Member

I would suggest putting the minimum Julia version to 1.0. You also need to add a version number (0.4)

@dpsanders
Copy link
Member

And you can remove the require file

@yashvardhan747
Copy link
Contributor Author

Version 0.4 of what ?

@dpsanders
Copy link
Member

Version 0.4 of IntervalOptimisation.jl

@dpsanders
Copy link
Member

Ah we are dropping support for Julia 0. 7 so it should be version 0.4. This is what you should say in news.md

@yashvardhan747
Copy link
Contributor Author

ok I'll correct it

@dpsanders dpsanders merged commit 09b52a4 into JuliaIntervals:master Jun 4, 2019
@dpsanders
Copy link
Member

Thanks!

@dpsanders
Copy link
Member

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b364c38). Learn more about missing BASE report.
⚠️ Report is 14 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   67.90%           
=========================================
  Files             ?        4           
  Lines             ?       81           
  Branches          ?        0           
=========================================
  Hits              ?       55           
  Misses            ?       26           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants