Skip to content

Commit 913d2ef

Browse files
authored
Refer to ticket LEMS-3686 in the comments for using CSS modules with WB (#3003)
## Summary: There are a number of TODO comments in the code saying to switch to CSS modules once Wonder Blocks has support for it, but there was no ticket to point to. I just created a ticket (LEMS-3686) and updated all the existing TODO comments to refer to that ticket. Issue: none ## Test plan: N/A Author: nishasy Reviewers: mark-fitzgerald, catandthemachines, ivyolamit, SonicScrewdriver, anakaren-rojas Required Reviewers: Approved By: mark-fitzgerald, catandthemachines Checks: ✅ 10 checks were successful Pull Request URL: #3003
1 parent d0309d0 commit 913d2ef

File tree

7 files changed

+8
-5
lines changed

7 files changed

+8
-5
lines changed

.changeset/clever-seals-cover.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/perseus-editor/src/components/issue-cta.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const IssueCta = ({issue}: Props) => {
3333

3434
export default IssueCta;
3535

36-
// TODO: Use CSS modules after Wonder Blocks styles
36+
// TODO(LEMS-3686): Use CSS modules after Wonder Blocks styles
3737
// are moved to a different layer.
3838
const styles = {
3939
button: {

packages/perseus-editor/src/widgets/image-editor/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {sizing} from "@khanacademy/wonder-blocks-tokens";
22

3-
// TODO: Use CSS modules after Wonder Blocks styles
3+
// TODO(LEMS-3686): Use CSS modules after Wonder Blocks styles
44
// are moved to a different layer.
55
export const wbFieldStyles = {
66
root: {

packages/perseus-editor/src/widgets/interactive-graph-editor/interactive-graph-editor.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/* We have to use !important until wonder blocks is in the shared layer. */
2+
/* TODO(LEMS-3686): Remove the !important once we don't need it anymore. */
23
.single-select-short {
34
/* Non-standard spacing, but it's the smallest we can go
45
without running into styling issues with the dropdown. */

packages/perseus-editor/src/widgets/radio/radio-status-pill.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function RadioStatusPill({
2121
return (
2222
<Pill
2323
size="large"
24-
// TODO: Update to use CSS modules when we can
24+
// TODO(LEMS-3686): Update to use CSS modules when we can
2525
// use them with Wonder Blocks.
2626
style={{
2727
// Space between the pill and the text

packages/perseus/src/widgets/image/components/explore-image-modal-content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export default function ExploreImageModalContent({
9999
);
100100
}
101101

102-
// TODO: Use CSS modules after Wonder Blocks styles
102+
// TODO(LEMS-3686): Use CSS modules after Wonder Blocks styles
103103
// are moved to a different layer.
104104
const wbStyles = {
105105
descriptionHeading: {

packages/perseus/src/widgets/image/components/explore-image-modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const ExploreImageModal = (props: ImageDescriptionAndCaptionProps) => {
4646
);
4747
};
4848

49-
// TODO: Use CSS modules after Wonder Blocks styles
49+
// TODO(LEMS-3686): Use CSS modules after Wonder Blocks styles
5050
// are moved to a different layer.
5151
const wbStyles = {
5252
root: {

0 commit comments

Comments
 (0)