[Analytics] Adding more widget analytics events. #3039
Conversation
🗄️ Schema Change: No Changes ✅ |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: +79 B (+0.02%) Total Size: 498 kB
ℹ️ View Unchanged
|
…events to grapher, graded-group, graded-group-set, matrix, orderer, passage, and plotter
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5b50bd9) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3039If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3039If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3039 |
…n/more-analtyics-events
catandthemachines
requested review from
SonicScrewdriver,
anakaren-rojas,
ivyolamit and
mark-fitzgerald
as code owners
| PassageExport.widget.prototype, | ||
| "getReference", | ||
| ).mockImplementation(() => { | ||
| jest.spyOn(Passage.prototype, "getReference").mockImplementation(() => { |
There was a problem hiding this comment.
Chatted with @jeremywiebe if updating these tests for getReference signifies any concern for our exported experience for Passage widget. And we determined that this is just for testing purposes, and isn't a concern for our Passage Ref needs for perseus. Let me know if anyone has any other concerns with this implementation.
|
|
||
| import type {APIOptions} from "../../../types"; | ||
|
|
||
| function renderPassage( |
There was a problem hiding this comment.
This test function appeared outdated and not helpful. So I decided to update the tests to utilize our renderQuestion test function.
Summary:
Adding analytics events to the following widgets:
Issue: LEMS-XXXX
Test plan: