[Image] | (UX) | Image zoom fixes #3044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove ZoomService in favor of WB Modal
…e tested with unit tests
…e-zoom-with-modal
…han functions to remove hooks warning
…f screen on mobile
… zooming on Graphie images
…e-zoom-with-modal
…odal' into image-make-graphie-zoomable
…er than zoomed image
…om fixes - remove scrolling for portrait images, command click on main image instead of zoomed image
nishasy
requested review from
catandthemachines and
ivyolamit
as code owners
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +119 B (+0.02%) Total Size: 497 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c55e364) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3044If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3044If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3044 |
catandthemachines
approved these changes
Nov 18, 2025
Member
catandthemachines
left a comment
catandthemachines
left a comment
There was a problem hiding this comment.
Approved! I do have a concern over the constant of a WB modal that is not based on wonder blocks styling. I would love for that to get fixed or have a follow-up ticket to update that code in the future.
| import styles from "./zoomed-image-view.module.css"; | ||
|
|
||
| // 32px on each side of the modal panel | ||
| const WB_MODAL_PADDING_TOTAL = 64; |
Member
There was a problem hiding this comment.
Is there a way you can get this value dynamically? I can see a future where WB updates their modal padding and this value will require manual updating from us.
…e-zoom-with-modal
…odal' into image-make-graphie-zoomable
… into image-graphie-zoom-fixes
… into image-graphie-zoom-fixes
Merged
nishasy
added a commit
that referenced
this pull request
Nov 20, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#3037](#3037) [`39c890acc5`](39c890a) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Allow zooming on Graphie images - [#3009](#3009) [`8d3beb2743`](8d3beb2) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (DX) | Remove ZoomService in favor of WB Modal ### Patch Changes - [#3044](#3044) [`78e15ef4e6`](78e15ef) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Image zoom fixes - remove scrolling for portrait images, command click on main image instead of zoomed image - [#3043](#3043) [`98245b0f3a`](98245b0) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Fix bottom margin when rendering in mobile - Updated dependencies \[[`ceb7a70bfa`](ceb7a70), [`fc6273b10d`](fc6273b), [`18261c3294`](18261c3)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#3047](#3047) [`b84bc99def`](b84bc99) Thanks [@nishasy](https://github.com/nishasy)! - Add Issues Panel to Article Editor - [#2992](#2992) [`fc6273b10d`](fc6273b) Thanks [@nishasy](https://github.com/nishasy)! - Add radio and expression save wanrnings to the perseus linter. Add a callback for issues changed to item-editor.tsx. - [#3037](#3037) [`39c890acc5`](39c890a) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Allow zooming on Graphie images ### Patch Changes - [#3044](#3044) [`78e15ef4e6`](78e15ef) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Image zoom fixes - remove scrolling for portrait images, command click on main image instead of zoomed image - [#3049](#3049) [`18261c3294`](18261c3) Thanks [@nishasy](https://github.com/nishasy)! - Add Free Response widget save warnings to perseus linter - Updated dependencies \[[`ceb7a70bfa`](ceb7a70), [`78e15ef4e6`](78e15ef), [`fc6273b10d`](fc6273b), [`39c890acc5`](39c890a), [`8d3beb2743`](8d3beb2), [`98245b0f3a`](98245b0), [`18261c3294`](18261c3)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#2992](#2992) [`fc6273b10d`](fc6273b) Thanks [@nishasy](https://github.com/nishasy)! - Add radio and expression save wanrnings to the perseus linter. Add a callback for issues changed to item-editor.tsx. - [#3049](#3049) [`18261c3294`](18261c3) Thanks [@nishasy](https://github.com/nishasy)! - Add Free Response widget save warnings to perseus linter ## @khanacademy/[email protected] ### Patch Changes - [#3054](#3054) [`ceb7a70bfa`](ceb7a70) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Add tabs and icon button package in math-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differences found
Fixes in this PR:
I also changed the Portraid Image story to have a bigger portrait for better
edge case testing.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3689
Test plan:
Storybook
/?path=/story/widgets-image-widget-demo--image-portrait