refactor: improve qrcode generation

Author: catrielmuller

webview-ui/src/utils/kilocode/qrcode.ts

@@ -1,68 +1,41 @@
 import QRCode from "qrcode"
 
-/**
- * Generate a QR code as a data URL
- * @param text The text to encode in the QR code
- * @param options QR code generation options
- * @returns Promise resolving to a data URL string
- */
-export async function generateQRCode(
-	text: string,
-	options?: {
-		width?: number
-		margin?: number
-		color?: {
-			dark?: string
-			light?: string
-		}
-	},
-): Promise<string> {
-	try {
-		const dataUrl = await QRCode.toDataURL(text, {
-			width: options?.width ?? 200,
-			margin: options?.margin ?? 2,
-			color: {
-				dark: options?.color?.dark ?? "#000000",
-				light: options?.color?.light ?? "#FFFFFF",
-			},
-		})
-		return dataUrl
-	} catch (error) {
-		console.error("Failed to generate QR code:", error)
-		throw new Error(`Failed to generate QR code: ${error instanceof Error ? error.message : String(error)}`)
+interface QRCodeOptions {
+	width?: number
+	margin?: number
+	color?: {
+		dark?: string
+		light?: string
 	}
 }
 
-/**
- * Generate a QR code as an SVG string
- * @param text The text to encode in the QR code
- * @param options QR code generation options
- * @returns Promise resolving to an SVG string
- */
-export async function generateQRCodeSVG(
-	text: string,
-	options?: {
-		width?: number
-		margin?: number
-		color?: {
-			dark?: string
-			light?: string
-		}
+const DEFAULT_OPTIONS = {
+	width: 200,
+	margin: 2,
+	color: {
+		dark: "#000000",
+		light: "#FFFFFF",
 	},
-): Promise<string> {
-	try {
-		const svg = await QRCode.toString(text, {
-			type: "svg",
-			width: options?.width ?? 200,
-			margin: options?.margin ?? 2,
-			color: {
-				dark: options?.color?.dark ?? "#000000",
-				light: options?.color?.light ?? "#FFFFFF",
-			},
-		})
-		return svg
-	} catch (error) {
-		console.error("Failed to generate QR code SVG:", error)
-		throw new Error(`Failed to generate QR code SVG: ${error instanceof Error ? error.message : String(error)}`)
+} as const
+
+function buildQRCodeOptions(options?: QRCodeOptions) {
+	return {
+		width: options?.width ?? DEFAULT_OPTIONS.width,
+		margin: options?.margin ?? DEFAULT_OPTIONS.margin,
+		color: {
+			dark: options?.color?.dark ?? DEFAULT_OPTIONS.color.dark,
+			light: options?.color?.light ?? DEFAULT_OPTIONS.color.light,
+		},
 	}
 }
+
+export async function generateQRCode(text: string, options?: QRCodeOptions): Promise<string> {
+	return QRCode.toDataURL(text, buildQRCodeOptions(options))
+}
+
+export async function generateQRCodeSVG(text: string, options?: QRCodeOptions): Promise<string> {
+	return QRCode.toString(text, {
+		type: "svg",
+		...buildQRCodeOptions(options),
+	})
+}