Skip to content

Commit 1610db1

Browse files
committed
Add tracking issue in TODO comment
Signed-off-by: Francesco Giudici <[email protected]>
1 parent e8791bc commit 1610db1

File tree

5 files changed

+6
-1
lines changed

5 files changed

+6
-1
lines changed

controller/hybridgateway/plugin/plugin.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ func PluginForFilter(
8686
annotationManager.AppendRouteToAnnotation(&plugin, httpRoute)
8787

8888
// TODO: we should check that the existingPlugin.Spec matches what we expect
89+
// https://github.com/Kong/kong-operator/issues/2687
8990
log.Debug(logger, "Successfully updated existing KongPlugin")
9091

9192
return &plugin, nil

controller/hybridgateway/pluginbinding/pluginbinding.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ func BindingForPluginAndRoute(
9393
annotationManager.AppendRouteToAnnotation(&binding, httpRoute)
9494

9595
// TODO: we should check that the existingBinding.Spec matches what we expect
96+
// https://github.com/Kong/kong-operator/issues/2687
9697
log.Debug(logger, "Successfully updated existing KongPluginBinding")
9798

9899
return &binding, nil

controller/hybridgateway/service/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ func ServiceForRule(
9595
annotationManager.AppendRouteToAnnotation(&service, httpRoute)
9696

9797
// TODO: we should check that the existingService.Spec matches what we expect
98+
// https://github.com/Kong/kong-operator/issues/2687
9899
log.Debug(logger, "Successfully updated existing KongService")
99100

100101
return &service, nil

controller/hybridgateway/target/target.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,7 @@ func createTargetsFromValidBackendRefs(ctx context.Context, logger logr.Logger,
437437
annotationManager.AppendRouteToAnnotation(&target, httpRoute)
438438

439439
// TODO: we should check that the existingTarget.Spec matches what we expect
440+
// https://github.com/Kong/kong-operator/issues/2687
440441
log.Debug(logger, "Successfully updated existing KongTarget")
441442

442443
targets = append(targets, target)

controller/hybridgateway/upstream/upstream.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ func UpstreamForRule(
8989
annotationManager := metadata.NewAnnotationManager(logger)
9090
annotationManager.AppendRouteToAnnotation(&upstream, httpRoute)
9191

92-
// TODO: we should check that the existingUpstream.Spec matches what we expect and error out if not
92+
// TODO: we should check that the existingUpstream.Spec matches what we expect
93+
// https://github.com/Kong/kong-operator/issues/2687
9394
log.Debug(logger, "Successfully updated existing KongUpstream")
9495

9596
return &upstream, nil

0 commit comments

Comments
 (0)