fix: correct Azure DNSConfig mapping and rename typo (#2550)

Signed-off-by: Jintao Zhang <[email protected]>
Co-authored-by: Jakub Warczarek <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>

Author: 3 people

controller/konnect/ops/ops_konnecttransitgateway.go

@@ -142,15 +142,15 @@ func getKonnectTransitGatewayMatchingSpecName(
 	return getMatchingEntryFromListResponseData(listTransitGatewayResponseDataToEntityWithIDSlice(resp.ListTransitGatewaysResponse.Data), tg)
 }
 
-var trasitGatewayTypeToSDKTransitGatewayType = map[konnectv1alpha1.TransitGatewayType]sdkkonnectcomp.CreateTransitGatewayRequestType{
+var transitGatewayTypeToSDKTransitGatewayType = map[konnectv1alpha1.TransitGatewayType]sdkkonnectcomp.CreateTransitGatewayRequestType{
 	konnectv1alpha1.TransitGatewayTypeAWSTransitGateway:   sdkkonnectcomp.CreateTransitGatewayRequestTypeAWSTransitGateway,
 	konnectv1alpha1.TransitGatewayTypeAzureTransitGateway: sdkkonnectcomp.CreateTransitGatewayRequestTypeAzureTransitGateway,
 }
 
 func transitGatewaySpecToTransitGatewayInput(
 	spec konnectv1alpha1.KonnectTransitGatewayAPISpec,
 ) sdkkonnectcomp.CreateTransitGatewayRequest {
-	typ := trasitGatewayTypeToSDKTransitGatewayType[spec.Type]
+	typ := transitGatewayTypeToSDKTransitGatewayType[spec.Type]
 
 	req := sdkkonnectcomp.CreateTransitGatewayRequest{
 		Type: typ,
@@ -176,7 +176,7 @@ func transitGatewaySpecToTransitGatewayInput(
 	case konnectv1alpha1.TransitGatewayTypeAzureTransitGateway:
 		req.AzureTransitGateway = &sdkkonnectcomp.AzureTransitGateway{
 			Name: spec.AzureTransitGateway.Name,
-			DNSConfig: lo.Map(spec.AWSTransitGateway.DNSConfig, func(dnsConf konnectv1alpha1.TransitGatewayDNSConfig, _ int) sdkkonnectcomp.TransitGatewayDNSConfig {
+			DNSConfig: lo.Map(spec.AzureTransitGateway.DNSConfig, func(dnsConf konnectv1alpha1.TransitGatewayDNSConfig, _ int) sdkkonnectcomp.TransitGatewayDNSConfig {
 				return sdkkonnectcomp.TransitGatewayDNSConfig{
 					RemoteDNSServerIPAddresses: dnsConf.RemoteDNSServerIPAddresses,
 					DomainProxyList:            dnsConf.DomainProxyList,

controller/konnect/ops/ops_konnecttransitgateway_test.go

@@ -19,6 +19,35 @@ import (
 	"github.com/kong/kong-operator/test/mocks/sdkmocks"
 )
 
+func TestTransitGatewaySpecToInput_AzureDNSConfig(t *testing.T) {
+	spec := konnectv1alpha1.KonnectTransitGatewayAPISpec{
+		Type: konnectv1alpha1.TransitGatewayTypeAzureTransitGateway,
+		AzureTransitGateway: &konnectv1alpha1.AzureTransitGateway{
+			Name: "az-tg",
+			DNSConfig: []konnectv1alpha1.TransitGatewayDNSConfig{
+				{RemoteDNSServerIPAddresses: []string{"10.1.0.1", "10.1.0.2"}, DomainProxyList: []string{"internal.example.com", "corp.local"}},
+			},
+			AttachmentConfig: konnectv1alpha1.AzureVNETPeeringAttachmentConfig{
+				TenantID:          "tenant-1",
+				SubscriptionID:    "sub-1",
+				ResourceGroupName: "rg-1",
+				VnetName:          "vnet-1",
+			},
+		},
+	}
+
+	req := transitGatewaySpecToTransitGatewayInput(spec)
+
+	require.NotNil(t, req.AzureTransitGateway)
+	az := req.AzureTransitGateway
+	if assert.Len(t, az.DNSConfig, 1) {
+		cfg := az.DNSConfig[0]
+		assert.ElementsMatch(t, []string{"10.1.0.1", "10.1.0.2"}, cfg.RemoteDNSServerIPAddresses)
+		assert.ElementsMatch(t, []string{"internal.example.com", "corp.local"}, cfg.DomainProxyList)
+	}
+	assert.Equal(t, sdkkonnectcomp.CreateTransitGatewayRequestTypeAzureTransitGateway, req.Type)
+}
+
 func TestAdoptMatchTransitGatewaySuccess(t *testing.T) {
 	t.Parallel()