Added ability to play sounds with notification #156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to set sound for each TSMessageNotificationType. Added ability to set default sound for all notifications.
Commit after calling ‘pod update’ to ensure proper integration of framework in pod.
Author
|
I wasn't paying attention and committed everything to the master branch. I can move it to the dev branch if thats easier to test. |
Collaborator
|
on which branch did you worked? because the develop branch got a complete revamp from @dennisreimann for version 1.0 |
Author
|
I put my work in the master branch. In my zeal, I honestly forgot to look at the development branch, so I'll check into it and make my changes there later today. |
Author
Collaborator
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to set a default sound to play when a notification appears, as well as the ability to set a sound for each notification type. If a notification type has no sound set, it will fall back to the default sound if one is set.
I updated the example project as well, so you can test it out there.
Let me know what you think.